Skip to content

feat: mediaprojection improvements for android 14 and above #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArthurKun21 wants to merge 6 commits into
base: master
Choose a base branch
from
+22 −5
Open

feat: mediaprojection improvements for android 14 and above #2083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c8b1fd
feat: add support for full screen capture for android 15 and above
ArthurKun21 Aug 20, 2025
2051252
fix: do not clone on android 14 and above
ArthurKun21 Nov 25, 2025
f3c67bf
fix: force not null intent
ArthurKun21 Nov 25, 2025
a9c1875
fix: move comment to relevant line
ArthurKun21 Nov 25, 2025
3858cfe
fix: Update the media projection token checker to handle null tokens
ArthurKun21 Nov 25, 2025
b205e96
fix: re-added the force non-null assertion operator and add fallback …
ArthurKun21 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions app/src/main/java/io/github/fate_grand_automata/runner/ScreenshotServiceHolder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,24 @@ class ScreenshotServiceHolder @Inject constructor(

screenshotService = try {
if (prefs.wantsMediaProjectionToken) {
// Cloning the Intent allows reuse.
// Otherwise, the Intent gets consumed and MediaProjection cannot be started multiple times.
val token = ScriptRunnerService.mediaProjectionToken?.clone() as Intent
if (ScriptRunnerService.mediaProjectionToken == null) {
throw IllegalStateException("Media projection token is null")
}
val token = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
ScriptRunnerService.mediaProjectionToken!!
} else {
try {
// Cloning the Intent allows reuse.
// Otherwise, the Intent gets consumed and MediaProjection cannot be started multiple times.
ScriptRunnerService.mediaProjectionToken?.clone() as Intent
} catch (e: Exception) {
ScriptRunnerService.mediaProjectionToken!!
}
}

val mediaProjection =
mediaProjectionManager.getMediaProjection(Activity.RESULT_OK, token)

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
// not allowed to reuse tokens on Android 14
ScriptRunnerService.mediaProjectionToken = null
Expand Down
8 changes: 7 additions & 1 deletion app/src/main/java/io/github/fate_grand_automata/ui/StartMediaProjection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,20 @@ package io.github.fate_grand_automata.ui
import android.app.Activity
import android.content.Context
import android.content.Intent
import android.media.projection.MediaProjectionConfig
import android.media.projection.MediaProjectionManager
import android.os.Build
import androidx.activity.result.contract.ActivityResultContract

class StartMediaProjection : ActivityResultContract<Unit, Intent?>() {
override fun createIntent(context: Context, input: Unit): Intent {
val mediaProjectionManager = context.getSystemService(MediaProjectionManager::class.java)

return mediaProjectionManager.createScreenCaptureIntent()
return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) {
mediaProjectionManager.createScreenCaptureIntent(MediaProjectionConfig.createConfigForDefaultDisplay())
} else {
mediaProjectionManager.createScreenCaptureIntent()
}
}

override fun parseResult(resultCode: Int, intent: Intent?) =
Expand Down
Loading