feat: Mighty / Color chain + NP type detection implementation#2087
feat: Mighty / Color chain + NP type detection implementation#2087Vylantze wants to merge 132 commits intoFate-Grand-Automata:masterfrom
Conversation
Build 1021Download the latest APK for testing here Note You need a GitHub account to download the APK. This URL is valid as long as the artifact has not expired yet. |
…using a crash because infinite loop). Also fix using cards instead of justRearranged because it does not provide the full 5 cards.
Add handling for rearrange. Moves mighty chain tests to MightyChainTest and add more tests.
… should default to the fallback scenario)
|
As of 553985c update, I have added a beta NP type checker to the system. This will mean that the NP type is automatically detected, which means that priority for each wave won't be needed anymore. Flaws / Potential bugs:
Other than that, it works!! |
|
@vybze I ran it a few more times. I can't get BB to recheck and make her use a non-Mighty chain in that setup. If you can replicate it elsewhere, it would be great. Also, my runs have additionally gotten destroyed by BB not charging enough with Arts card as first card, and then Douman insta-killing the middle enemy... |
Made a longer video |
I can't replicate it at all... Would you be willing to go on discord and we debug it together in Android Studio? |
You can always find me on the fga discord server |
scripts/src/main/java/io/github/fate_grand_automata/scripts/enums/AttackPriorityEnum.kt
Show resolved
Hide resolved
… to fix a detection bug caused by lag.
Copilot suggestion Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Previous prebuild had expired, so I forced a new one to be built and am putting the link here if anyone wants to use it. EDIT: Latest link will instead be in the main post. |







Download Link to Prebuild APK
R.string.p_brave_chains_with_np_mightyfor all languageswithNPimplementation as the baseline and then modifies the final result of that to pull off a Mighty chain if possible (if not, it returns the normal result ofwithNP).EDIT: Intended Mighty chain implementation added with NP card detection (beta).
Screenshots
The config that was used to test is below. The map used is the current 90++ map in JP summer event 2025.
Event Box Farm.fga.json
Task List
Edit: Moved task list here for easier tracking
None,WithNP,Always,Avoid).Buster,Arts,Quick)Buster,Arts,Quick)None,WithNP,Always,Avoid)None,WithNP,Always,Avoid).None).I intend to do the tasks from top down. The actual implementation changes will only change slightly (depending on what unexpected behaviors I find) while I perform these tasks. Most of the general cases should have a confirmed behavior already. The one most tested at the moment (particularly with actual testing in FGO) is
WithNP, because that covers majority of the use cases.Flowchart
Show