feat: add detection for strengthened skills

[sheng-28]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related Issue

• Fixed Check skill strengthening check in support selection #2056

Description

• Implemented detection of the strengthened skills based on max skill detection
• Added UI in PREFERRED setting
• Currently allows detection of up to 2 strengthening each skill, can change to allow more in the UI(PreferredSupportScreen.kt)
• Added skill_strengthened.png and skill_unstrengthened.png to assets
• Added detection of unstrengthened template if strengthened template is not found, when neither could be detected the script would be interrupted and user would be prompted to check configuration
• Verified via setting Emiya and Gilgamesh as preferred support in Daily Quests and Grand Duel on NA and JP server running on BlueStacks Air
• Might need translations

Screenshots

Buttons added under Max Skills setting


Screenshot of a match in debug mode


Screenshot of a mis-match in debug mode


Screenshot of exit prompt when required strengthening couldn't be found e.g. Gilgamesh with strengthening requirement of [1, 0, 2]

[github-actions]

Build 929

Download the latest APK for testing here

Note

You need a GitHub account to download the APK.

This URL is valid as long as the artifact has not expired yet.

[ArthurKun21]

Thanks for the hard work!

[sheng-28]

btw, have you tested this on Grand Duels?

Last night I asked someone from Discord to test it on Grand Duels, the first version works fine with Emiya according to them

[ArthurKun21]

Could you also add checking if there's the non-strengthened skill?

so that if neither the strengthened nor not strengthened template image were found it means automatically 0 so we can either throw an error with the configuration set not found or just let it pass as true

[sheng-28]

Could you also add checking if there's the non-strengthened skill?

so that if neither the strengthened nor not strengthened template image were found it means automatically 0 so we can either throw an error with the configuration set not found or just let it pass as true

That's a good idea, I'll add a detection for non-strengthened template when the strengthened template is not found, and throw a notification to let the user know if there's no strengthening at all for that skill.

[ArthurKun21]

btw, if you are finished with this PR. Ping reconman on discord so he can take a look

[Copilot]

Pull request overview

Adds a new support-selection filter to detect whether a support servant’s skills have been strengthened (rank-up cleared), alongside UI controls to configure the requirement and an explicit script exit reason when templates can’t be detected.

Changes:

• Add strengthened-skill detection in preferred support selection and expose three per-skill strengthened requirements in support preferences.
• Add Preferred Support UI controls (and a note dialog) to configure strengthened skill requirements.
• Add new image templates and a new battle exit reason + UI string mapping for “strengthened skill empty”.

Reviewed changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
scripts/src/main/java/io/github/fate_grand_automata/scripts/supportSelection/ServantSelection.kt	Adds strengthened-skill filtering + detection logic during preferred support matching.
scripts/src/main/java/io/github/fate_grand_automata/scripts/prefs/ISupportPreferences.kt	Adds strengthened-skill preference fields to scripts-facing support prefs interface.
scripts/src/main/java/io/github/fate_grand_automata/scripts/locations/SupportScreenLocations.kt	Introduces a new region constant intended for strengthened-skill icon detection.
scripts/src/main/java/io/github/fate_grand_automata/scripts/entrypoints/AutoBattle.kt	Adds a new ExitReason for strengthened-skill template/detection failure.
scripts/src/main/java/io/github/fate_grand_automata/scripts/Images.kt	Registers new image identifiers for strengthened/unstrengthened templates.
prefs/src/main/java/io/github/fate_grand_automata/prefs/core/SupportPrefsCore.kt	Persists strengthened-skill preferences (ints) in prefs core.
prefs/src/main/java/io/github/fate_grand_automata/prefs/SupportPreferences.kt	Wires prefs core strengthened-skill fields into the scripts preferences implementation.
app/src/main/res/values/localized.xml	Adds strings for the new UI section, note, and exit message.
app/src/main/java/io/github/fate_grand_automata/ui/pref_support/PreferredSupportScreen.kt	Adds UI controls for configuring strengthened-skill requirements and an info dialog.
app/src/main/java/io/github/fate_grand_automata/ui/exit/BattleExit.kt	Maps the new ExitReason to a user-facing message.
app/src/main/assets/Jp/skill_strengthened.png	Adds strengthened template image asset (JP folder).
app/src/main/assets/En/skill_unstrengthened.png	Adds unstrengthened template image asset (EN folder).
app/src/main/assets/En/skill_strengthened.png	Adds strengthened template image asset (EN folder).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[ArthurKun21]

I think you could try to request another test on discord and ping Lord FGA so it can be brought to his attention