Skip to content

Fix: correct Persian weekday names#30

Merged
FatulM merged 2 commits intoFatulM:masterfrom
rezazoom:master
Oct 10, 2025
Merged

Fix: correct Persian weekday names#30
FatulM merged 2 commits intoFatulM:masterfrom
rezazoom:master

Conversation

@rezazoom
Copy link
Contributor

Summary

Adjusted the Persian calendar weekday names to use correct spacing.

Details

  • Updated all weekday names to follow standard Persian orthography.
    • e.g., "یکشنبه" instead of "یک شنبه"
  • No changes to logic or ordering, only textual corrections.

Impact

Improves display consistency and accuracy for Persian weekday names.

@rezazoom
Copy link
Contributor Author

Documented on this article

@FatulM FatulM self-assigned this Aug 24, 2025
@FatulM FatulM added the enhancement New feature or request label Aug 24, 2025
Copy link
Owner

@FatulM FatulM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I think in your links the week day names are different from your commit.
They should be:

[[شنبه]]
[[یک‌شنبه]]
[[دوشنبه]]
[[سه‌شنبه]]
[[چهارشنبه]]
[[پنج‌شنبه]]
|[[جمعه]]
Some have half spaces.
Also please fix tests, docs and example files, If they have incorrect week day names.

@rezazoom
Copy link
Contributor Author

Hello.
Thanks for reviewing my PR.

No weekday name should contain half-spaces excluding "سه‌شنبه" only because it contains "ـه"
All other weekday names should be combined together as WikiPedia doc says above.

@rezazoom rezazoom requested a review from FatulM August 25, 2025 04:39
Copy link
Owner

@FatulM FatulM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s ok.
But I should all parts which are affected, when I have time.
Thanks.

@FatulM
Copy link
Owner

FatulM commented Oct 6, 2025

Did you edit the Wikipedia docs yourself ?
😄
I checked it and it was edited …

@FatulM
Copy link
Owner

FatulM commented Oct 6, 2025

I have one only one problem with merging this pull request.
This will change the results of using the library in a way that is considered a breaking change.
Am I correct ?
So I should change version to 2.0.
Otherwise the people who depend on it will get problems …

@rezazoom
Copy link
Contributor Author

rezazoom commented Oct 7, 2025

@FatulM I understand your concern, but I’d say it’s more of a correction than a breaking change — the previous weekday names contained incorrect spellings according to Persian orthography.
Users relying on the meaning of the names won’t be affected, only those who used the incorrect forms programmatically (which is unlikely).

So it could stay as a minor version bump instead of a major one — but I’m fine either way if you prefer to go with 2.0 for consistency.

@FatulM
Copy link
Owner

FatulM commented Oct 10, 2025

Thanks a lot,
I'll merge this PR.
I will later think about what to do with the versioning issue.

@FatulM FatulM merged commit 98d7586 into FatulM:master Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants