Skip to content

Conversation

@impact-basin
Copy link
Contributor

@impact-basin impact-basin commented Jan 18, 2026

Some tasks are best represented with different states -- e.g. one may be iterating over a collection, whilst another may be doing I/O and metering bytes per second, within the context of one ProgressBar() object.

This micro-PR allows for specification of ProgressJob columns at the point of addjob!() invocation. A minimal, arbitrary example:

p = ProgressBar(; columns=:default)
c1 = [DescriptionColumn, SeparatorColumn,  ProgressColumn, SpinnerColumn]
c2 = [CompletedColumn,   ProgressColumn, SeparatorColumn, SpinnerColumn]

with(p) do
    j1 = addjob!(p; columns=c1, N=100)
    j2 = addjob!(p; columns=c2, N=100)
    for _ in 1:100
        update!.([j1, j2])
        sleep(0.01)
    end
end

@impact-basin
Copy link
Contributor Author

Accidentally based this off the hline PR - my bad. Rebased to drop those commits - though I've just seen it's merged.

@impact-basin
Copy link
Contributor Author

impact-basin commented Jan 18, 2026

Forgot to import SpinnerColumn in the test suite :-) the dangers of SLIME...

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.01%. Comparing base (440ce2c) to head (9a664a0).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   87.27%   88.01%   +0.74%     
==========================================
  Files          48       48              
  Lines        2899     2912      +13     
==========================================
+ Hits         2530     2563      +33     
+ Misses        369      349      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-bltg
Copy link
Collaborator

t-bltg commented Jan 18, 2026

Can you fix the failing format check test ?

@impact-basin
Copy link
Contributor Author

Yep, getting to it now

@impact-basin
Copy link
Contributor Author

@t-bltg -- as you can probably tell, I don't use Git much besides as a glorified CVS or SVN, and so generally only use the master branch in my stuff. Such is life being the only programmer in my group (and I'm an electrical engineer masquerading as a physicist before all that).

I have idiotically merged this tree into #279 by mistake; I can close this if you want and you can just pull that?

@impact-basin
Copy link
Contributor Author

Closing in favour of #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants