-
-
Notifications
You must be signed in to change notification settings - Fork 41
Per-Job Columns #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-Job Columns #277
Conversation
a0d16fc to
a4da95d
Compare
|
Accidentally based this off the hline PR - my bad. Rebased to drop those commits - though I've just seen it's merged. |
|
Forgot to import SpinnerColumn in the test suite :-) the dangers of SLIME... |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 87.27% 88.01% +0.74%
==========================================
Files 48 48
Lines 2899 2912 +13
==========================================
+ Hits 2530 2563 +33
+ Misses 369 349 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you fix the failing |
|
Yep, getting to it now |
|
@t-bltg -- as you can probably tell, I don't use Git much besides as a glorified CVS or SVN, and so generally only use the master branch in my stuff. Such is life being the only programmer in my group (and I'm an electrical engineer masquerading as a physicist before all that). I have idiotically merged this tree into #279 by mistake; I can close this if you want and you can just pull that? |
|
Closing in favour of #279 |
Some tasks are best represented with different states -- e.g. one may be iterating over a collection, whilst another may be doing I/O and metering bytes per second, within the context of one ProgressBar() object.
This micro-PR allows for specification of ProgressJob columns at the point of addjob!() invocation. A minimal, arbitrary example: