Skip to content

Fix variable and function naming warnings #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix variable and function naming warnings #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a50bcb
Rename centroid relative position var to address compiler warning
trizko Sep 20, 2025
0ef0d54
Rename latest_event_id function to address var shadowing warning
trizko Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CustomInputEvents/InputEventScreenPinch.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ func _init(_raw_gesture : RawGesture = null, event : InputEventScreenDrag = null

distance = 0
for drag in raw_gesture.drags.values():
var centroid_relative_position = drag.position - position
distance += centroid_relative_position.length()
var _centroid_relative_position = drag.position - position
distance += _centroid_relative_position.length()

var centroid_relative_position = event.position - position
relative = ((centroid_relative_position + event.relative).length() - centroid_relative_position.length())
Expand Down
4 changes: 2 additions & 2 deletions RawGesture.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ func rollback_absolute(time : float) -> Array:
var discarded_events : Array = []
var rg : RawGesture = copy()

var latest_event_id : Array = rg.latest_event_id(time)
var latest_event_id : Array = rg.get_latest_event_id(time)
while !latest_event_id.is_empty():
var latest_index : int = latest_event_id[0]
var latest_type : String = latest_event_id[1]
Expand Down Expand Up @@ -176,7 +176,7 @@ func copy() -> RawGesture:
rg.elapsed_time = elapsed_time
return rg

func latest_event_id(latest_time : float = -1) -> Array:
func get_latest_event_id(latest_time : float = -1) -> Array:
var res : Array = []
for index in history:
for type in history[index]:
Expand Down