Make the Windows installer translatable#927
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds translation infrastructure for the Windows NSIS installer by introducing two Python scripts that extract and merge translatable strings with the project's translation system, enabling Windows installer messages to be translated through Weblate.
Changes:
- Added
extract-nsis-strings.pyto extract English strings from NSIS language files into POT format - Added
generate-nsis-translations.pyto merge PO translations back into NSIS language file format - Updated build scripts to integrate NSIS string extraction and translation generation into the existing translation workflow
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| po/extract-nsis-strings.py | New script to extract translatable strings from NSIS installer files |
| po/generate-nsis-translations.py | New script to generate NSIS language file with translations from PO files |
| po/generate-pot-files.sh | Updated to include NSIS string extraction in the POT generation process |
| po/build-translations.sh | Updated to generate NSIS translations during the build process |
| po/mediawriter.pot | Updated with extracted NSIS strings and regenerated with new timestamp |
| dist/win/languages.nsh | Reformatted with consistent spacing and normalized to use English as fallback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gastoner
left a comment
gastoner
left a comment
There was a problem hiding this comment.
Left two comments otherwise codewise LGTM
|
Looks like the translation is working (although on latest release it looks same I think), but we are missing one extra translation with uninstaling: Also only on this build this happens to me on Win: |
grulja
force-pushed
the
installer-translations
branch
from
ff8722f to
244ec41
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This adds two Python scripts that extract messages from the Windows installer so we can have them translated in Weblate and reassemble again the installer script with the translations we have available. Both Python scripts were created using Claude Code. Fixes FedoraQt#926
grulja
force-pushed
the
installer-translations
branch
from
244ec41 to
37472f2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
This adds two Python scripts that extract messages from the Windows installer so we can have them translated in Weblate and reassemble again the installer script with the translations we have available.
Both Python scripts were created using Claude Code.
Fixes #926