Skip to content

Fixes display of mj-sections with background image in some Outlook versions#60

Merged
FelixSchwarz merged 2 commits intoFelixSchwarz:mainfrom
pagestrip:main
Jan 9, 2025
Merged

Fixes display of mj-sections with background image in some Outlook versions#60
FelixSchwarz merged 2 commits intoFelixSchwarz:mainfrom
pagestrip:main

Conversation

@bvallant
Copy link
Contributor

@bvallant bvallant commented Jan 8, 2025

The output for mj-sections using a background image is wrong compared with the original MJML implementation; the <v:rect> tag was incorrectly closed (though there was a closing tag already coming afterwards) and the order of some Outlook specific tags was wrong.
Note that these things don't get caught in the tests, most likely because they are conditional HTML comments.

@bvallant bvallant changed the title Fixes display of mj-sections with background imagein some Outlook versions Fixes display of mj-sections with background image in some Outlook versions Jan 8, 2025
@FelixSchwarz FelixSchwarz merged commit 49fa14e into FelixSchwarz:main Jan 9, 2025
9 checks passed
@FelixSchwarz
Copy link
Owner

Thank you for spotting this problem - somehow I messed up when I created the initial port. Indeed, these problems won't be detected in our current testing. I hope you did not have to spend a lot of time debugging this.

@bvallant
Copy link
Contributor Author

bvallant commented Jan 9, 2025

I hope you did not have to spend a lot of time debugging this.

Well I did. 😿 But I guess that's more Outlook's fault!

@skaaks
Copy link

skaaks commented May 9, 2025

@FelixSchwarz Currently, we have monkey-patched this in our project. When I noticed this PR couple of months ago, I was hoping to see a new version with this upstream fix. Any timelines for releasing this fix?

Thanks.

@FelixSchwarz
Copy link
Owner

you are right, a release is overdue. I pushed some more modernizations and will do a release later today.

@FelixSchwarz
Copy link
Owner

Just wanted to mention that I just extended htmlcompare so this kind of issue would be found automatically in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants