Fixes display of mj-sections with background image in some Outlook versions#60
Fixes display of mj-sections with background image in some Outlook versions#60FelixSchwarz merged 2 commits intoFelixSchwarz:mainfrom
Conversation
|
Thank you for spotting this problem - somehow I messed up when I created the initial port. Indeed, these problems won't be detected in our current testing. I hope you did not have to spend a lot of time debugging this. |
Well I did. 😿 But I guess that's more Outlook's fault! |
|
@FelixSchwarz Currently, we have monkey-patched this in our project. When I noticed this PR couple of months ago, I was hoping to see a new version with this upstream fix. Any timelines for releasing this fix? Thanks. |
|
you are right, a release is overdue. I pushed some more modernizations and will do a release later today. |
|
Just wanted to mention that I just extended htmlcompare so this kind of issue would be found automatically in the future. |
The output for mj-sections using a background image is wrong compared with the original MJML implementation; the
<v:rect>tag was incorrectly closed (though there was a closing tag already coming afterwards) and the order of some Outlook specific tags was wrong.Note that these things don't get caught in the tests, most likely because they are conditional HTML comments.