Skip to content

refactor(global-exception-handler): unify exception handling and redu… #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isanort merged 2 commits into from
Oct 3, 2025
Merged

refactor(global-exception-handler): unify exception handling and redu… #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12e0bfa
refactor(global-exception-handler): unify exception handling and redu…
thaisrqueiroz Oct 3, 2025
9e5ce8d
test(exceptions): update global exception handler with grouped handlers
isanort Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 48 additions & 111 deletions src/main/java/com/SleepUp/SU/exceptions/GlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,53 +25,35 @@
@RestControllerAdvice
public class GlobalExceptionHandler {

@ExceptionHandler(InvalidDateRangeException.class)
public ResponseEntity<ErrorResponse> handleInvalidDateRangeException(InvalidDateRangeException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.BAD_REQUEST;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(UserNotFoundByIdException.class)
public ResponseEntity<ErrorResponse> handleUserNotFoundByIdeException(UserNotFoundByIdException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.NOT_FOUND;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(UserNotFoundByUsernameException.class)
public ResponseEntity<ErrorResponse> handleUserNotFoundByUsernameException(UserNotFoundByUsernameException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.NOT_FOUND;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(UserEmailAlreadyExistsException.class)
public ResponseEntity<ErrorResponse> handleUserEmailAlreadyExists(UserEmailAlreadyExistsException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.CONFLICT;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(UserUsernameAlreadyExistsException.class)
public ResponseEntity<ErrorResponse> handleUserUsernameAlreadyExists(UserUsernameAlreadyExistsException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.CONFLICT;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(AccommodationNotFoundByIdException.class)
public ResponseEntity<ErrorResponse> handleAccommodationNotFoundByIdException(AccommodationNotFoundByIdException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.NOT_FOUND;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(AccommodationAlreadyExistsByNameException.class)
public ResponseEntity<ErrorResponse> handleAccommodationAlreadyExistsByName(AccommodationAlreadyExistsByNameException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.CONFLICT;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
@ExceptionHandler({
UserNotFoundByIdException.class,
UserNotFoundByUsernameException.class,
AccommodationNotFoundByIdException.class,
ReservationNotFoundByIdException.class
})
public ResponseEntity<ErrorResponse> handleNotFound(RuntimeException ex, HttpServletRequest req) {
return buildResponse(HttpStatus.NOT_FOUND, ex.getMessage(), req);
}

@ExceptionHandler({
UserEmailAlreadyExistsException.class,
UserUsernameAlreadyExistsException.class,
AccommodationAlreadyExistsByNameException.class,
ReservationOverlapException.class,
ReservationModificationException.class,
ReservationAccommodationOwnerException.class
})
public ResponseEntity<ErrorResponse> handleConflict(RuntimeException ex, HttpServletRequest req) {
return buildResponse(HttpStatus.CONFLICT, ex.getMessage(), req);
}

@ExceptionHandler({
InvalidDateRangeException.class,
AccommodationConstraintsException.class,
AccommodationUnavailableException.class
})
public ResponseEntity<ErrorResponse> handleBadRequest(RuntimeException ex, HttpServletRequest req) {
return buildResponse(HttpStatus.BAD_REQUEST, ex.getMessage(), req);
}

@ExceptionHandler(MethodArgumentNotValidException.class)
Expand All @@ -82,9 +64,8 @@ public ResponseEntity<ErrorResponse> handleValidationExceptions(MethodArgumentNo
String errorMessage = error.getDefaultMessage();
errors.put(fieldName, errorMessage);
});
HttpStatus status = HttpStatus.BAD_REQUEST;
ErrorResponse body = new ErrorResponse(status, "VALIDATION_ERROR", errors, request);
return ResponseEntity.status(status).body(body);

return buildResponse(HttpStatus.BAD_REQUEST, exception.getMessage(), request);
}

@ExceptionHandler(ConstraintViolationException.class)
Expand All @@ -95,87 +76,43 @@ public ResponseEntity<ErrorResponse> handleConstraintViolationExceptions(Constra
String errorMessage = error.getMessage();
errors.put(fieldName, errorMessage);
});
HttpStatus status = HttpStatus.BAD_REQUEST;
ErrorResponse body = new ErrorResponse(status, "CONSTRAINT_VIOLATION", errors, request);
return ResponseEntity.status(status).body(body);

return buildResponse(HttpStatus.BAD_REQUEST, exception.getMessage(), request);
}

@ExceptionHandler(HttpMessageNotReadableException.class)
public ResponseEntity<ErrorResponse> handleEmptyOrMalformedBodyRequest(HttpMessageNotReadableException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.BAD_REQUEST;

String message = "Request body is required and cannot be empty or malformed.";
ErrorResponse body = new ErrorResponse(status, message, request);
return ResponseEntity.status(status).body(body);

return buildResponse(HttpStatus.BAD_REQUEST, message, request);
}

@ExceptionHandler(AccessDeniedException.class)
public ResponseEntity<ErrorResponse> handleAccessDeniedException(AccessDeniedException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.FORBIDDEN;
ErrorResponse body = new ErrorResponse(status, "Access Denied. You are not authorized to execute this action. " + exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(BadCredentialsException.class)
public ResponseEntity<ErrorResponse> handleBadCredentialsException(BadCredentialsException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.UNAUTHORIZED;
ErrorResponse body = new ErrorResponse(status, "Unauthorized: Bad credentials", request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(ReservationNotFoundByIdException.class)
public ResponseEntity<ErrorResponse> handleReservationNotFoundByIdeException(ReservationNotFoundByIdException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.NOT_FOUND;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}
String message = "Access denied. You are not authorized to execute this action." + exception.getMessage();

@ExceptionHandler(AccommodationConstraintsException.class)
public ResponseEntity<ErrorResponse> handleAccommodationConstraintsException(
AccommodationConstraintsException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.BAD_REQUEST;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
return buildResponse(HttpStatus.FORBIDDEN, message, request);
}

@ExceptionHandler(AccommodationUnavailableException.class)
public ResponseEntity<ErrorResponse> handleAccommodationUnavailableException(
AccommodationUnavailableException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.BAD_REQUEST;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}
@ExceptionHandler(ReservationOverlapException.class)
public ResponseEntity<ErrorResponse> handleReservationOverlapException(
ReservationOverlapException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.CONFLICT;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}

@ExceptionHandler(ReservationModificationException.class)
public ResponseEntity<ErrorResponse> handleReservationModificationException(
ReservationModificationException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.CONFLICT;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
}
@ExceptionHandler(BadCredentialsException.class)
public ResponseEntity<ErrorResponse> handleBadCredentialsException(BadCredentialsException exception, HttpServletRequest request) {

@ExceptionHandler(ReservationAccommodationOwnerException.class)
public ResponseEntity<ErrorResponse> handleReservationAccommodationOwnerException(
ReservationAccommodationOwnerException exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.CONFLICT;
ErrorResponse body = new ErrorResponse(status, exception.getMessage(), request);
return ResponseEntity.status(status).body(body);
return buildResponse(HttpStatus.UNAUTHORIZED, "Unauthorized: Bad credentials", request);
}

@ExceptionHandler(Exception.class)
public ResponseEntity<ErrorResponse> handleAllUnhandledExceptions(Exception exception, HttpServletRequest request) {
HttpStatus status = HttpStatus.INTERNAL_SERVER_ERROR;

Map<String, String> errors = new HashMap<>();
errors.put("error", exception.getMessage() != null ? exception.getMessage() : "Unexpected error");

ErrorResponse body = new ErrorResponse(status, errors, request);
return ResponseEntity.status(status).body(body);
return buildResponse(HttpStatus.INTERNAL_SERVER_ERROR, errors, request);
}
}

private ResponseEntity<ErrorResponse> buildResponse(HttpStatus status, Object message, HttpServletRequest request) {
return ResponseEntity.status(status).body(new ErrorResponse(status, message, request));
}

}
Loading
Loading