Skip to content

Revert "feat(email-service-helper): make email sending asynchronous using @As…" #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isanort merged 1 commit into from
Oct 6, 2025
Merged

Revert "feat(email-service-helper): make email sending asynchronous using @As…" #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/com/SleepUp/SU/SuApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,10 @@

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.scheduling.annotation.EnableAsync;
import org.springframework.scheduling.annotation.EnableScheduling;

@SpringBootApplication
@EnableScheduling
@EnableAsync
public class SuApplication {

public static void main(String[] args) {
Expand Down
15 changes: 1 addition & 14 deletions src/main/java/com/SleepUp/SU/utils/email/EmailServiceHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import lombok.RequiredArgsConstructor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.scheduling.annotation.Async;
import org.springframework.stereotype.Service;

import java.math.BigDecimal;
Expand Down Expand Up @@ -38,7 +37,6 @@ public void validateEmailConfig() {
}
}

@Async
public void sendWelcomeEmail(User user) {
try {
emailService.sendWelcomeEmail(user);
Expand All @@ -48,7 +46,6 @@ public void sendWelcomeEmail(User user) {
}
}

@Async
public void sendOwnerReservedNotification(Reservation reservation) {
try {
emailService.sendOwnerReservedNotification(reservation);
Expand All @@ -58,7 +55,6 @@ public void sendOwnerReservedNotification(Reservation reservation) {
}
}

@Async
public void sendReservationConfirmationEmail(Reservation reservation, BigDecimal discountAmount) {
try {
emailService.sendGuestReservationConfirmationEmail(reservation, discountAmount);
Expand All @@ -68,7 +64,6 @@ public void sendReservationConfirmationEmail(Reservation reservation, BigDecimal
}
}

@Async
public void sendReservationReminderEmail(Reservation reservation) {
try {
emailService.sendGuestReservationReminderEmail(reservation);
Expand All @@ -78,7 +73,6 @@ public void sendReservationReminderEmail(Reservation reservation) {
}
}

@Async
public void sendOwnerReservationReminderEmail(Reservation reservation) {
try {
emailService.sendOwnerReservationReminderEmail(reservation);
Expand All @@ -88,7 +82,6 @@ public void sendOwnerReservationReminderEmail(Reservation reservation) {
}
}

@Async
public void sendCancellationConfirmationEmail(Reservation reservation) {
try {
emailService.sendCancellationConfirmationEmail(reservation);
Expand All @@ -98,7 +91,6 @@ public void sendCancellationConfirmationEmail(Reservation reservation) {
}
}

@Async
public void sendCancellationByOwnerNotificationEmail(Reservation reservation) {
try {
emailService.sendCancellationByOwnerNotificationEmail(reservation);
Expand All @@ -108,7 +100,6 @@ public void sendCancellationByOwnerNotificationEmail(Reservation reservation) {
}
}

@Async
public void sendCancellationNotificationToOwnerEmail(Reservation reservation) {
try {
emailService.sendCancellationNotificationToOwnerEmail(reservation);
Expand All @@ -118,7 +109,6 @@ public void sendCancellationNotificationToOwnerEmail(Reservation reservation) {
}
}

@Async
public void handleNewReservationEmails(Reservation reservation, BigDecimal discountAmount) {
logger.info("Processing emails for new reservation - Guest: {}, Accommodation: {}",
reservation.getUser().getEmail(), reservation.getAccommodation().getName());
Expand All @@ -129,7 +119,6 @@ public void handleNewReservationEmails(Reservation reservation, BigDecimal disco
logger.info("New reservation email processing completed");
}

@Async
public void handleGuestCancellationEmails(Reservation reservation) {
logger.info("Processing emails for guest cancellation - Guest: {}, Accommodation: {}",
reservation.getUser().getEmail(), reservation.getAccommodation().getName());
Expand All @@ -140,7 +129,6 @@ public void handleGuestCancellationEmails(Reservation reservation) {
logger.info("Guest cancellation email processing completed");
}

@Async
public void handleOwnerCancellationEmails(Reservation reservation) {
logger.info("Processing emails for owner cancellation - Guest: {}, Accommodation: {}",
reservation.getUser().getEmail(), reservation.getAccommodation().getName());
Expand All @@ -150,7 +138,6 @@ public void handleOwnerCancellationEmails(Reservation reservation) {
logger.info("Owner cancellation email processing completed");
}

@Async
public void sendReservationReminders(Reservation reservation) {
logger.info("Sending reservation reminders - Guest: {}, Owner: {}, Accommodation: {}",
reservation.getUser().getEmail(), reservation.getAccommodation().getManagedBy().getEmail(), reservation.getAccommodation().getName());
Expand Down Expand Up @@ -192,4 +179,4 @@ public boolean canSendReservationEmails(Reservation reservation) {

return true;
}
}
}
Loading