DRAFT foamfix unload entities patch #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created concurrentmodificationexceptions for me about 10 times per day on a server. it was missing one line that forge probably added after that foamfix patch was made (2017)
Contributor
Author
|
testing this fix for the next few days on my server, will undraft if it works |
Contributor
Author
|
still crashes, will have to modify further |
checking with @debug revealed that it didnt apply the mixin at all. i guess with some mixin magic (mixin into worldserver instead of the patch class of foamfix?) it could be done but this should work too will test on my server
Contributor
Author
|
i fat fingered that "ready for review" button, will first test for the next few days on server |
Contributor
Author
|
still crashes, added logging now |
"Actually now that i have a bit better knowledge of the spawning logic, skipping not fully loaded chunks might have been the better move after all. Vanilla varies its mob cap depending on how many of the expected eligiblechunks are actually eligible So with low render it would just reduce mob cap automatically. With my old fix it would still fill up the loaded chunks with the full mobcap, but with the usual speed "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created concurrentmodificationexceptions for me about 10 times per day on a server. it was missing one line that forge probably added after that foamfix patch was made (2017)