Skip to content

Conversation

YellowRoseCx
Copy link

Really cool app! It's the only GUI ADB File Browser I've found that works on Linux. However, I noticed the current linux releases don't work on the still very popular Ubuntu 22.04 version since the Github runner ubuntu-latest uses 24.04; it gives the error:

./desktop_adb_file_browser: symbol lookup error: ./desktop_adb_file_browser: undefined symbol: g_once_init_enter_pointer

when trying to run.

This PR does two main things:

  • Adds a build for Ubuntu 22.04 LTS. The workflow was previously only building for ubuntu-latest (24.04). Since 22.04 is a very popular LTS release, adding a separate build for it will help ensure compatibility and provide a dedicated binary for users on that system.

  • Fixes the release job. While adding the new build target, I noticed that the download-artifact action places each artifact into its own named subdirectory (e.g., artifacts/windows-x64-msix/, artifacts/linux-22.04-x64/, etc.). The final release step was pointing to the wrong paths, which would have caused the release to fail to find the files. I've updated all the paths to point to the correct locations.

With these changes, the workflow should now correctly:

  • Build successfully on macOS, Windows, Ubuntu 22.04, and Ubuntu 24.04
  • Create a GitHub Release with all the correct installer files and archives attached when a tag is pushed

@Fernthedev
Copy link
Owner

Hi, thanks for the PR. Are you sure it resolves the issue? Might as well just use only Ubuntu 22.04 if it does.

As for the Github release workflow, pretty sure it works as is. The archive extraction is rather strange which is why you'll see multiple commits related to it.

@YellowRoseCx
Copy link
Author

Hi, thanks for the PR. Are you sure it resolves the issue? Might as well just use only Ubuntu 22.04 if it does.

As for the Github release workflow, pretty sure it works as is. The archive extraction is rather strange which is why you'll see multiple commits related to it.

I don't have any systems running 24.04 so I can't check if building with ubuntu-22.04 would work on ubuntu-24.04, but I have built and tested the release method and the resulting ubuntu-22.04 file https://github.com/YellowRoseCx/desktop_adb_file_browser-ubuntu_22.0.4/releases/tag/v1.4.4-test

and the thing with the release is the code was this:

- name: Create Release
        uses: softprops/action-gh-release@v1
        with:
          files: |
            artifacts/windows-x64/desktop_adb_file_browser.msix
            artifacts/windows-x64/windows-x64 Inno installer.exe

but unless I'm misunderstanding, the MSIX file should be in artifacts/windows-x64-msix/ , not artifacts/windows-x64/.
and the same for the Inno installer, in artifacts/windows-x64 Inno installer/ instead of artifacts/windows-x64/

but now I do see that desktop_adb_file_browser.msix is also included in the windows_x64 folder, but that windows_installer.exe isn't, so yeah

@Fernthedev
Copy link
Owner

Upon further inspection, I'm wondering if this PR resolves the issue. It doesn't do anything more than build the project in a new matrix called linux-22.04 which is identical to the previous one. Both are ubuntu-latest. Are you sure this works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants