fix_node_order! function

[KnutAM]

As this happens from time to time for users loading from Gmsh, maybe this functionality that I did for an internal project we have could be relevant here.

Would be a solution for e.g. #15 without having to use Gmsh commands, which is useful if Gmsh is run from another software (e.g. neper).

Of course, this functionality could be in Ferrite too since it doesn't really interact with Gmsh, but on the other hand, this problem only seems to arise for Gmsh.

The few tests I've conducted indicate that it's fast enough to be used as a safe (perhaps even default) option when loading a Gmsh grid, but in that case, I guess the order of the vertex- and facetsets should be preserved?

Let me know if this functionality is desired here.

As reference, here is also code I used to visually validate it in addition to the tests,

# `get_nodeset_from_set` in test file
function export_bsets(grid, name = "bsets")
    VTKGridFile(name, grid) do vtk
        for key in keys(grid.facetsets)
            nodes = get_nodeset_from_set(grid, getfacetset(grid, key))
            export_nodes(vtk, grid, nodes, "facets_$key")
        end
        for key in keys(grid.vertexsets)
            nodes = get_nodeset_from_set(grid, getvertexset(grid, key))
            export_nodes(vtk, grid, nodes, "vertex_$key")
        end
    end
end

[KnutAM]

Error: Missing download info for actions/cache@v1

Failure seems unrelated, outdated actions?

[termi-official]

Error: Missing download info for actions/cache@v1

Failure seems unrelated, outdated actions?

xref #32

[termi-official]

CI is back online.

[termi-official]

Can we add a meaningful error error for 3D and a bypass for 1D?

[KnutAM]

Of course, this functionality could be in Ferrite too since it doesn't really interact with Gmsh, but on the other hand, this problem only seems to arise for Gmsh.

We also had this for grids from abaqus input files (ref), perhaps should be added to Ferrite then?

[termi-official]

Should we add such geometry processing stuff into Ferrite directly or a package like FerriteGeometry/FerriteMeshTools/...?

[KnutAM]

I think I’m Ferrite directly makes more sense as long as not too exotic to avoid a jungle of packages and if it doesn’t add more deps