Make deformation of wireframe work for superparametric elements#121
Open
KnutAM wants to merge 1 commit intoFerrite-FEM:masterfrom
Open
Make deformation of wireframe work for superparametric elements#121KnutAM wants to merge 1 commit intoFerrite-FEM:masterfrom
KnutAM wants to merge 1 commit intoFerrite-FEM:masterfrom
Conversation
termi-official
approved these changes
Feb 14, 2024
koehlerson
reviewed
Apr 11, 2024
| return data | ||
| # reshape_to_nodes gives either [Nx1] or [Nx3] to match vtk expectations | ||
| # Makie doesn't support view in to_vertices, so we have to collect: | ||
| return collect(transpose(view(data, 1:field_dim, :))) |
Member
There was a problem hiding this comment.
ah thats annoying but seems like no other option than collecting?
Member
Author
There was a problem hiding this comment.
From the comment below, looks like I haven't tested with reinterpreted array, but not sure if even a transposed array works... But if it does, I guess one could branch for 2d and collect only for that case. For master / v1 the vtk-style output ([Nx1] / [Nx3]) could also be used instead of Vector{Vec}, but that is using an internal Ferrite detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes 2nd part of #119
Minimum reproducer
On master gives the following error
Details
Added some draft code for how this could be adopted to Ferrite#master / v1.0