Provide function to extract the value from a dual tensor#208
Open
KnutAM wants to merge 5 commits intoFerrite-FEM:masterfrom
Open
Provide function to extract the value from a dual tensor#208KnutAM wants to merge 5 commits intoFerrite-FEM:masterfrom
KnutAM wants to merge 5 commits intoFerrite-FEM:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 17 17
Lines 1490 1492 +2
=======================================
+ Hits 1444 1446 +2
Misses 46 46
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the updated docstring for example and motivation, and this example, where the internal
_extract_valueis used, is a "real-world" use case.Tensor.extract_valueis defined (exclusively forAbstractTensorinput) and documented in this PR. For scalarsForwardDiff.valueshould be used.Due to the relatively generic name and fairly advanced (and not very frequent) use case, I think it is better to not export it, making it very clear that it is exclusively for tensors.