Skip to content

remove SIMD.jl#93

Open
fredrikekre wants to merge 1 commit intomasterfrom
fe/SIMD.jl
Open

remove SIMD.jl#93
fredrikekre wants to merge 1 commit intomasterfrom
fe/SIMD.jl

Conversation

@fredrikekre
Copy link
Member

Probably not needed with llvm6 and SLP vectorization enabled by default.

@codecov-io
Copy link

codecov-io commented May 7, 2018

Codecov Report

Merging #93 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   98.01%   97.74%   -0.27%     
==========================================
  Files          15       15              
  Lines         755      755              
==========================================
- Hits          740      738       -2     
- Misses         15       17       +2
Impacted Files Coverage Δ
src/Tensors.jl 100% <ø> (ø) ⬆️
src/eigen.jl 86.66% <0%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6391974...95277c5. Read the comment docs.

@KristofferC
Copy link
Collaborator

No explicit SIMD:

julia> a = rand(Tensor{4,3});

julia> @which a ⊡ a
dcontract(S1::FourthOrderTensor{dim}, S2::FourthOrderTensor{dim}) where dim
     @ Tensors ~/.julia/dev/Tensors/src/tensor_products.jl:139

julia> @btime $a ⊡ $a;
  80.764 ns (0 allocations: 0 bytes)

Explicit SIMD:

julia> @which a ⊡ a
dcontract(S1::Tensor{4, 3, T}, S2::Tensor{4, 3, T}) where T<:Union{Float16, Float32, Float64}
     @ Tensors ~/.julia/dev/Tensors/src/simd.jl:279

julia> @btime $a ⊡ $a;
  58.187 ns (0 allocations: 0 bytes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants