-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add check activity column to provider tables #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
615a7aa
feat: add check activity column to provider tables
silent-cipher 7f8b3c4
refactor: rename to BaseProviderData and update type definition
silent-cipher 9e11e01
feat: disable sorting for check activity column
silent-cipher d270a71
chore: address review
silent-cipher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { ExternalTextLink } from '@filecoin-foundation/ui-filecoin/TextLink/ExternalTextLink' | ||
|
|
||
| type PdpScanLinkProps = { | ||
| pdpScanUrl: string | ||
| providerName: string | ||
| } | ||
|
|
||
| export function PdpScanLink({ pdpScanUrl, providerName }: PdpScanLinkProps) { | ||
| return ( | ||
| <ExternalTextLink | ||
| href={pdpScanUrl} | ||
| aria-label={`View activity for provider ${providerName} on PDP Scan`} | ||
| > | ||
| View on PDP Scan | ||
| </ExternalTextLink> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| import type { ServiceProvider } from '@/schemas/provider-schema' | ||
|
|
||
| /** | ||
| * Provider without software version (before version fetch) | ||
| * Base provider data from contract (before enrichment with software version and check activity URL) | ||
| */ | ||
| export type ProviderWithoutSoftwareVersion = Omit< | ||
| export type BaseProviderData = Omit< | ||
silent-cipher marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ServiceProvider, | ||
| 'softwareVersion' | ||
| 'softwareVersion' | 'checkActivityUrl' | ||
| > | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import type { Address } from 'viem' | ||
|
|
||
| import type { Network } from '@/config/chains' | ||
| import { EXPLORERS } from '@/constants/external-services' | ||
|
|
||
| /** | ||
| * Constructs the check activity URL for a provider on PDP Scan | ||
| * | ||
| * @param network - The network (mainnet or calibration) | ||
| * @param payeeAddress - The provider's payee address | ||
| * @returns The full URL to view provider activity on PDP Scan | ||
| */ | ||
| export function getCheckActivityUrl( | ||
| network: Network, | ||
| payeeAddress: Address, | ||
| ): string { | ||
| return `${EXPLORERS.PDP_SCAN[network]}${payeeAddress}` | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
checkActivityUrlis computed for every provider in a batch, but this is a synchronous operation that doesn't need to be inside the async map. Consider moving it outside the Promise.all to improve clarity and potentially performance, or compute it in a separate pass before the async operations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is synchronous operation but separation would require two iterations without meaningful benefit