Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@geomatrick FYI ~ Addressed mentioned comments:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the agents pages to improve maintainability by centralizing duplicated content that previously appeared in 7 separate RFS markdown files. The refactoring extracts shared sections ("Key Links", "A Note on FOC's Storage Model", and "SDK Maturity & Builder Expectations") into the [slug]/page.tsx layout component, and creates a reusable SubmitProposalButton component.
Changes:
- Extracted
SubmitProposalButtoncomponent for reuse across agents list and detail pages - Centralized shared content sections from individual RFS markdown files to the
[slug]/page.tsxlayout - Updated SEO title to "Agents: Requests for Startups" for better context
- Added
focStorageMcpURL to site metadata constants
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/constants/site-metadata.ts | Added focStorageMcp URL to the warmStorageService configuration |
| src/app/agents/page.tsx | Updated title, replaced inline button with SubmitProposalButton component, removed unused import |
| src/app/agents/components/SubmitProposalButton.tsx | New reusable button component for proposal submission |
| src/app/agents/[slug]/page.tsx | Replaced MarkdownPage with article tag, added centralized Key Links and SDK information sections |
| src/app/agents/constants/seo.ts | Updated SEO title to include "Agents:" prefix |
| src/app/agents/data/open-requests/rfs-*.md | Removed duplicated Key Links and SDK sections from all 7 RFS markdown files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <li> | ||
| <a href={FOC_URLS.warmStorageService.contactSourceCode}> | ||
| FOC Storage MCP | ||
| </a> | ||
| </li> | ||
| <li> | ||
| <a href={FOC_URLS.warmStorageService.synapseSdk}>Synapse SDK</a> | ||
| </li> |
There was a problem hiding this comment.
The external links should use the ExternalLink component instead of plain anchor tags. The codebase has an ExternalLink component (src/components/ExternalLink.tsx) that properly handles external links with security attributes (rel="noopener noreferrer" and target="_blank"). Using this component maintains consistency with the rest of the codebase.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📝 Description
Refactors the agents pages to improve maintainability by centralizing shared content and extracting the CTA button into a reusable component.
🛠️ Key Changes
SubmitProposalButtoncomponent for reuse across agents pages[slug]/page.tsxlayoutfocStorageMcpURL to site metadata constants📌 To-Do Before Merging