-
Notifications
You must be signed in to change notification settings - Fork 4
Create dynamic sitemap with static and agent routes #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,34 @@ | ||
| import type { MetadataRoute } from 'next' | ||
|
|
||
| import { BASE_URL } from '@/constants/site-metadata' | ||
|
|
||
| export default function sitemap(): MetadataRoute.Sitemap { | ||
| return [ | ||
| { | ||
| url: BASE_URL, | ||
| lastModified: new Date(), | ||
| changeFrequency: 'weekly', | ||
| priority: 1, | ||
| }, | ||
| ] | ||
| import type { MetadataRoute } from "next"; | ||
|
|
||
| import { getAllRFSData } from "@/app/agents/utils/get-rfs-data"; | ||
| import { PATHS } from "@/constants/paths"; | ||
| import { BASE_URL } from "@/constants/site-metadata"; | ||
|
|
||
| export default async function sitemap(): Promise<MetadataRoute.Sitemap> { | ||
| const staticRoutes = getStaticRoutes(); | ||
| const agentRoutes = await getAgentRoutes(); | ||
|
|
||
| return [...staticRoutes, ...agentRoutes]; | ||
| } | ||
|
|
||
| const lastModified = new Date(); | ||
mirhamasala marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| function getStaticRoutes() { | ||
| return Object.values(PATHS).map(({ path }) => ({ | ||
| url: `${BASE_URL}${path}`, | ||
| lastModified, | ||
| changeFrequency: "weekly" as const, | ||
| priority: path === "/" ? 1 : 0.8, | ||
| })); | ||
| } | ||
|
|
||
| async function getAgentRoutes() { | ||
| const allRFSData = await getAllRFSData(); | ||
|
|
||
| return allRFSData.map(({ slug }) => ({ | ||
| url: `${BASE_URL}${PATHS.AGENTS.path}/${slug}`, | ||
| lastModified, | ||
| changeFrequency: "weekly" as const, | ||
| priority: 0.7, | ||
| })); | ||
| } | ||
mirhamasala marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sitemap function doesn't include error handling for the async
getAllRFSData()call. If this function fails (e.g., due to file system errors or invalid markdown), the entire sitemap generation will fail, potentially breaking the site's /sitemap.xml endpoint. Consider adding a try-catch block to handle errors gracefully, either by logging and returning only static routes, or by ensuring getAllRFSData has its own error handling. The pattern in src/app/agents/[slug]/page.tsx (lines 20-86) shows similar async data fetching with try-catch error handling.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getAllRFSDatareads local markdown files that are committed to the repo. Any failures (missing files, invalid frontmatter) would surface at build time when Next.js pre-renders the agent pages, well before the sitemap is generated. So a try-catch here wouldn't add meaningful resilience in practice.