feat: Automate fetching of USDFC contract ABI #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2025
rvagg
reviewed
Oct 7, 2025
| KEYSTORE ?= | ||
| PASSWORD ?= | ||
| CHALLENGE_FINALITY ?= | ||
| USDFC_PROXY_ADDRESS ?= 0x80B98d3aa09ffff255c3ba4A241111Ff1262F045 |
There was a problem hiding this comment.
Suggested change
| USDFC_PROXY_ADDRESS ?= 0x80B98d3aa09ffff255c3ba4A241111Ff1262F045 | |
| # Mainnet address by default | |
| USDFC_PROXY_ADDRESS ?= 0x80B98d3aa09ffff255c3ba4A241111Ff1262F045 |
rvagg
reviewed
Oct 7, 2025
Comment on lines
+4
to
+5
| # Fetches the ABI for a Filecoin proxy contract's implementation and saves it. | ||
| # |
There was a problem hiding this comment.
Suggested change
| # Fetches the ABI for a Filecoin proxy contract's implementation and saves it. | |
| # | |
| # Fetches the ABI for a Filecoin mainnet proxy contract's implementation and saves it. | |
| # |
rvagg
reviewed
Oct 7, 2025
Comment on lines
+79
to
+83
| echo "$IMPL_RESPONSE" | jq '.abi | fromjson' > "$OUTPUT_PATH" || { | ||
| # Clean up the potentially empty/corrupt file on failure. | ||
| rm -f "$OUTPUT_PATH" 2>/dev/null | ||
| die "Failed to parse ABI. The '.abi' field may be missing, null, or not valid JSON." | ||
| } |
There was a problem hiding this comment.
This should be more graceful - you could send it to a temporary file and then move it to OUTPUT_PATH, but the way this is now, a failure to fetch will leave you with a deleted ABI file in your repo.
|
lgtm, just some minor notes |
|
I just saw FilOzone/synapse-sdk#281 (comment) so I'll let @hugomrdias tell us which way this has to go to get it into synapse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a precursor to solve FilOzone/synapse-sdk#244. The SDK requires the full USDFC ABI to integrate features that use extensions like ERC-2612 and ERC-3009. This PR provides a reliable, automated way to source that ABI.
Problem
Previously, we used a generic
ERC20ABI which lacks support for theERC-2612andERC-3009specific extensions. This required manual ABI additions and could lead to discrepancies, blocking integration insynapse-sdk.Solution
tools/fetch-usdfc-abi.sh, is added. It resolves the USDFC proxy address to its underlying implementation contract and fetches the correct ABIMakefileis updated to integrate the script. The USDFC ABI can be fetched on-demand with makeabi/Usdfc.abi.jsonand is also automatically updated with all other contracts when runningmake update-abiThis streamlines the process of keeping the ABI in sync with the deployed contract and ensures all necessary function definitions are available.