feat(pricing): make pricing constants mutable with owner-controlled u… #325

rjan90 · 2025-10-23T12:00:24Z

Makes the three pricing rate constants mutable storage variables instead of immutable, enabling future price adjustments without requiring contract upgrades.

Changes

Pricing Variables: Converted STORAGE_PRICE_PER_TIB_PER_MONTH, CACHE_MISS_PRICE_PER_TIB_PER_MONTH, and CDN_PRICE_PER_TIB_PER_MONTH from immutable constants to mutable storage variables
New Function: Added updatePricing() - owner-only function that allows selective updates to pricing rates (pass 0 to keep existing value)
New Getter: Added getCurrentPricingRates() - public view function to query current pricing values
New Event: Added PricingUpdated event to track pricing changes
Lockup Amounts: DEFAULT_CDN_LOCKUP_AMOUNT and DEFAULT_CACHE_MISS_LOCKUP_AMOUNT remain immutable as they are not expected to change

Impact

New price rates will apply to all active data sets on their next proving period update (via nextProvingPeriod())

rjan90 · 2025-10-23T12:40:25Z

I had to make the pricing variables use camelCase (storagePricePerTibPerMonth, cacheMissPricePerTibPerMonth, cdnPricePerTibPerMonth) to match the existing storage variable convention in the contract (e.g., maxProvingPeriod, serviceCommissionBps): c7aa970.

Because without it the generated files check was failing.

wjmelements · 2025-10-23T16:27:45Z

service_contracts/src/FilecoinWarmStorageService.sol

+        view
+        returns (uint256 storagePrice, uint256 cacheMissPrice, uint256 cdnPrice)
+    {
+        return (storagePricePerTibPerMonth, cacheMissPricePerTibPerMonth, cdnPricePerTibPerMonth);


I think these cdn rates should be zero after #237. Might be an oversight in that PR. I have raised this question on slack.

looks like they noticed before I did #324

service_contracts/src/FilecoinWarmStorageService.sol

wjmelements

I think we should have a reasonable upper bound (eg 4x the initial value) on these numbers enforced by the contract. Increasing the rates above that boundary should require a contract upgrade via announcePlannedUpgrade.

rjan90 · 2025-10-23T16:50:08Z

I think we should have a reasonable upper bound (eg 4x the initial value) on these numbers enforced by the contract. Increasing the rates above that boundary should require a contract upgrade via announcePlannedUpgrade.

I think that makes sense. Will implement

rvagg · 2025-10-24T06:24:58Z

Will have to be reconciled with #320 depending on which is merged first. We'll want to be able to add MINIMUM_STORAGE_RATE_PER_MONTH to the update function.

rjan90 · 2025-10-24T06:28:00Z

Happy to let #320 to get merged first, and then followup here.

…pdates - Convert STORAGE_PRICE_PER_TIB_PER_MONTH, CACHE_MISS_PRICE_PER_TIB_PER_MONTH, and CDN_PRICE_PER_TIB_PER_MONTH from immutable to storage variables - Add updatePricing() owner-only function to update pricing rates - Add getCurrentPricingRates() getter function - Add PricingUpdated event to track pricing changes

fix: make update-abi

chore: make abi-gen

Rebased on main to incorporate floor pricing changes (commit 6cb08ce) and made MINIMUM_STORAGE_RATE_PER_MONTH mutable to enable runtime updates. Changes: - Converted minimumStorageRatePerMonth from immutable to storage variable - Added MAX_MINIMUM_STORAGE_RATE_PER_MONTH (0.24 USDFC, 4x initial 0.06) - Updated updatePricing() to accept newMinimumRate parameter - Updated PricingUpdated event to include minimumRate - Updated getCurrentPricingRates() to return both storage price and minimum rate - Added AtLeastOnePriceMustBeNonZero and PriceExceedsMaximum errors - Updated all references throughout contract to use camelCase variable names

rjan90 · 2025-10-24T21:12:28Z

I have reconciled this PR with the changes coming from #320 now, and added MINIMUM_STORAGE_RATE_PER_MONTH to the update function.

service_contracts/src/FilecoinWarmStorageService.sol

wjmelements · 2025-10-25T00:48:47Z

service_contracts/src/Errors.sol

+    /// @param priceType The type of price being updated (e.g., "storage", "minimumRate")
+    /// @param maxAllowed The maximum allowed value for this price type
+    /// @param actual The attempted value that exceeds the maximum
+    error PriceExceedsMaximum(string priceType, uint256 maxAllowed, uint256 actual);


we want to avoid strings in the code because solidity strings are a lot of codesize. They are actually the reason we are using these ABI errors.

There is a comparable situation where we are working around this with enum AddressField and another with enum CommissionType.

Alternatively you can use two different errors.

wjmelements

Prefer require() to if (){ revert() }
Avoid string constants.

Co-authored-by: William Morriss <[email protected]>

Address PR feedback to reduce code size by using enum instead of string literals in error definitions. Changes: - Add PriceType enum (Storage, MinimumRate) to Errors.sol - Update PriceExceedsMaximum error to use PriceType enum instead of string - Update error calls in updatePricing() to use Errors.PriceType.Storage/MinimumRate - Fix formatting issues in updatePricing() function

wjmelements · 2025-10-26T21:13:10Z

service_contracts/src/FilecoinWarmStorageService.sol

+     * @return minimumRate Current minimum monthly storage rate
+     */
+    function getCurrentPricingRates() external view returns (uint256 storagePrice, uint256 minimumRate) {
+        return (storagePricePerTibPerMonth, minimumStorageRatePerMonth);


rm or move to WarmStorageView lib

@rjan90

Reviewer @rjan90 We want view methods to use `extsload` because this reduces codesize. Codesize is a minor component of gas costs in the Filecoin EVM. #### Changes * mv getCurrentPricingRates to the View contract

rvagg · 2025-10-27T01:42:37Z

service_contracts/src/FilecoinWarmStorageService.sol

+        if (newStoragePrice > 0) {
+            require(
+                newStoragePrice <= MAX_STORAGE_PRICE_PER_TIB_PER_MONTH,
+                Errors.PriceExceedsMaximum(
+                    Errors.PriceType.Storage, MAX_STORAGE_PRICE_PER_TIB_PER_MONTH, newStoragePrice
+                )
+            );
+            storagePricePerTibPerMonth = newStoragePrice;
+        }
+        if (newMinimumRate > 0) {
+            require(
+                newMinimumRate <= MAX_MINIMUM_STORAGE_RATE_PER_MONTH,
+                Errors.PriceExceedsMaximum(
+                    Errors.PriceType.MinimumRate, MAX_MINIMUM_STORAGE_RATE_PER_MONTH, newMinimumRate
+                )
+            );
+            minimumStorageRatePerMonth = newMinimumRate;
+        }


I don't love having ifs here and am not sure "Pass 0 to keep existing value unchanged." is all that helpful. It might help with footguns, perhaps, but now there's no way to set a floor of 0, we'd have to use 1 to be our floor if we decided to undo that.
But, not a big deal if we're just trying to get this over the line at this point.

rjan90 · 2025-10-27T09:29:08Z

Will go ahead and merge as-is, since we are trying to get this over the line at this point, to unblock the release of FWSS contracts for GA

FilOzzy added this to FS Oct 23, 2025

github-project-automation bot moved this to 📌 Triage in FS Oct 23, 2025

rjan90 moved this from 📌 Triage to ⌨️ In Progress in FS Oct 23, 2025

rjan90 self-assigned this Oct 23, 2025

rjan90 added this to the M3: Preview Launch of SDK + Filecoin Pin milestone Oct 23, 2025

rjan90 linked an issue Oct 23, 2025 that may be closed by this pull request

Make pricing constants variable #306

Closed

rjan90 marked this pull request as ready for review October 23, 2025 12:54

rjan90 moved this from ⌨️ In Progress to 🔎 Awaiting review in FS Oct 23, 2025

rjan90 requested a review from wjmelements October 23, 2025 15:29

wjmelements reviewed Oct 23, 2025

View reviewed changes

service_contracts/src/FilecoinWarmStorageService.sol Outdated Show resolved Hide resolved

wjmelements reviewed Oct 23, 2025

View reviewed changes

rjan90 force-pushed the phi/price-variable branch from 1a61736 to ba45531 Compare October 24, 2025 06:29

rjan90 added 4 commits October 24, 2025 23:01

fix: make update-abi

9efacd0

fix: make update-abi

chore: make abi-gen

58df775

chore: make abi-gen

rjan90 force-pushed the phi/price-variable branch from ba45531 to 79ada50 Compare October 24, 2025 21:10

rjan90 requested a review from wjmelements October 24, 2025 21:11

wjmelements reviewed Oct 25, 2025

View reviewed changes

service_contracts/src/FilecoinWarmStorageService.sol Outdated Show resolved Hide resolved

wjmelements reviewed Oct 25, 2025

View reviewed changes

service_contracts/src/FilecoinWarmStorageService.sol Outdated Show resolved Hide resolved

wjmelements reviewed Oct 25, 2025

View reviewed changes

service_contracts/src/FilecoinWarmStorageService.sol Outdated Show resolved Hide resolved

wjmelements reviewed Oct 25, 2025

View reviewed changes

wjmelements requested changes Oct 25, 2025

View reviewed changes

github-project-automation bot moved this from 🔎 Awaiting review to ⌨️ In Progress in FS Oct 25, 2025

rjan90 and others added 4 commits October 26, 2025 20:15

Update service_contracts/src/FilecoinWarmStorageService.sol

f4b0e12

Co-authored-by: William Morriss <[email protected]>

Update service_contracts/src/FilecoinWarmStorageService.sol

6fae6e1

Co-authored-by: William Morriss <[email protected]>

Update service_contracts/src/FilecoinWarmStorageService.sol

b0667c7

Co-authored-by: William Morriss <[email protected]>

rjan90 requested a review from wjmelements October 26, 2025 20:04

wjmelements approved these changes Oct 26, 2025

View reviewed changes

github-project-automation bot moved this from ⌨️ In Progress to ✔️ Approved by reviewer in FS Oct 26, 2025

mv getCurrentPricingRates to View (#330)

09afd06

Reviewer @rjan90 We want view methods to use `extsload` because this reduces codesize. Codesize is a minor component of gas costs in the Filecoin EVM. #### Changes * mv getCurrentPricingRates to the View contract

wjmelements approved these changes Oct 27, 2025

View reviewed changes

rvagg reviewed Oct 27, 2025

View reviewed changes

rjan90 merged commit 6801108 into main Oct 27, 2025
6 checks passed

rjan90 deleted the phi/price-variable branch October 27, 2025 09:29

github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FS Oct 27, 2025

rjan90 mentioned this pull request Oct 27, 2025

build: prep FWSS v1.0.0 release #332

Merged

feat(pricing): make pricing constants mutable with owner-controlled u… #325

feat(pricing): make pricing constants mutable with owner-controlled u… #325

Uh oh!

Conversation

rjan90 commented Oct 23, 2025

Changes

Impact

Uh oh!

rjan90 commented Oct 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wjmelements left a comment

Choose a reason for hiding this comment

Uh oh!

rjan90 commented Oct 23, 2025

Uh oh!

rvagg commented Oct 24, 2025

Uh oh!

rjan90 commented Oct 24, 2025

Uh oh!

rjan90 commented Oct 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wjmelements left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rjan90 commented Oct 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants