Curio Market 2.0 - PDPv1 via @curio/market-client #200

snadrus · 2025-09-08T22:27:27Z

No description provided.

…oots->pieces Ref: FilOzone#105 feat!: owner -> storage provider & details rename fix!: address Curio endpoint renames, rename utils fix: address rename review feedback fix: address more rename review feedback fix: long tail of renames feat: contract functionality updates and fixes feat: more renaming & cleanup

Signed-off-by: Jakub Sztandera <[email protected]>

Almost all references to "CommP" are now gone. This includes exports.

Replaces createStorage() * synapse.storage.upload() and synapse.storage.download() for easy-path * StorageContext contains a relationship with a specific SP + data set * synapse.storage.createContext() to manage them directly * context.download() and context.upload() (etc.) for dealing directly with that SP + data set Closes: FilOzone#135

* feat(commpv2): Curio CommPv2 compatibility Ref: filecoin-project/curio#596 * chore: update contract addresses

FilOzone#158)

…ilOzone#159)

Bumps [chai](https://github.com/chaijs/chai) from 5.3.3 to 6.0.1. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/main/History.md) - [Commits](chaijs/chai@v5.3.3...v6.0.1) --- updated-dependencies: - dependency-name: chai dependency-version: 6.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

- add biome config and remove ts-standard - add simple-git-hooks to optionally setup biome for staged files pre-commit - changed from polendina to playwright-test for tests, couldn't get polendina to work. - add .vscode folder to auto setup biome extensions and settings

- Set "useAwait" to "off" and "noExplicitAny" to "off" in biome.json for now to many. - Update type definitions and comments across various files for clarity. - Simplify error handling in multiple catch blocks to improve readability. - Adjust test mocks to use consistent parameter naming conventions. - Updated the "test:watch" script in package.json to use "npm run" for consistency. - Removed redundant "source.fixAll.biome" setting from .vscode/settings.json to streamline configuration.

- Added new compiler options in tsconfig.json for improved module handling and strictness. - Refactored PDPServer to remove unnecessary await in PieceCID calculation for performance optimization. - Updated exports in piece/index.ts to use type exports for better clarity and maintainability. - Changed TypeScript version from "^5.8.3" to "5.8.3" to ensure consistent builds across environments. - Removed "DOM" and "DOM.Iterable" from the "lib" array in tsconfig.json to streamline the TypeScript configuration. - This change aims to reduce unnecessary library inclusions and improve build performance.

…es (FilOzone#173) Integrate KV metadata with Synapse Signed-off-by: Jakub Sztandera <[email protected]>

Ref: FilOzone/filecoin-services#144

…rage

Signed-off-by: Jakub Sztandera <[email protected]>

rjan90 · 2025-09-09T04:53:06Z

@snadrus Not sure if the intention if is to get this PR reviewed or its more for E2E on your end for now? But in general whenever something is ready for review, please be aware of the git-commit message guidelines, given that this repo has auto-publishing: https://github.com/FilOzone/synapse-sdk/blob/master/README.md#commit-message-guidelines

src/retriever/chain.ts

snadrus · 2025-09-10T23:23:48Z

@snadrus Not sure if the intention if is to get this PR reviewed or its more for E2E on your end for now? But in general whenever something is ready for review, please be aware of the git-commit message guidelines, given that this repo has auto-publishing: https://github.com/FilOzone/synapse-sdk/blob/master/README.md#commit-message-guidelines

sorry, I missed the 'draft' flag!

src/pdp/server.ts

rvagg · 2025-09-11T12:21:31Z

src/pdp/server-pdp0.ts

@@ -0,0 +1,547 @@
+/**
+ * PDPServer - Consolidated interface for all PDP server (Curio) HTTP operations


can trim this doc down to say that it's the v0 interface, no need to give it the full treatment in here if we retain the full form in server.ts

rvagg · 2025-09-11T12:22:59Z

src/pdp/server-pdp1.ts

+    const metadata = withCDN ? [this.getAuthHelper().WITH_CDN_METADATA] : []
+    // Generate the EIP-712 signature for data set creation
+    const authData = await this.getAuthHelper().signCreateDataSet(clientDataSetId, payee, metadata)
+
+    // Prepare the extra data for the contract call
+    // This needs to match the DataSetCreateData struct in Warm Storage contract
+    const extraData = this._encodeDataSetCreateData({
+      payer: await this.getAuthHelper().getSignerAddress(),
+      metadata,
+      signature: authData.signature,
+    })


you could extract these EIP-712 bits into a common utils file since it's going to be common regardless, extraData is going to pass through in the same form in both pathways

We have a need to keep the PDPv1 client self-standing, so I'd prefer avoiding a common utils for (what should be) this short-lived transition.

rvagg · 2025-09-11T12:27:51Z

src/pdp/server.ts

+    this._implPromise = this._selectBackend()
+  }
+
+  private async _selectBackend(): Promise<Backend> {


👍 is good

there's also a ping() operation (see method below in this file) we do at the very beginning when we set up a StorageContext to make sure the provider we select is alive and we can work with it (we filter them out if we don't get a response). This selection essentially serves as a "ping" for v1, and as long as we're chatting to the provider, maybe we should do something like:

const v1 = new PDPServerPdp0(this._authHelper, baseUrl) await v1.ping() return v1

and then our ping() in here becomes a noop and we get a ping every time we instantiate regardless of what it implements (plus also we never have to ping() a v1 since it's implicit in it returning a products list)

Ref: FilOzone#165 (review) was accidentally added originally

Fixes: FilOzone#157

…sier

* filCDNBeneficiaryAddress * fix test * fix checksum address

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.4.0 to 5.0.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4.4.0...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

## [0.24.0](FilOzone/synapse-sdk@v0.23.2...v0.24.0) (2025-09-05) ### Features * add synapse.storage and StorageContext ([FilOzone#153](FilOzone#153)) ([7485b84](FilOzone@7485b84)) * **commp:** transition to CommPv2 ([c0c39a4](FilOzone@c0c39a4)) * **commp:** use "PieceCID" terminology, use v2 exclusively ([81f9ea8](FilOzone@81f9ea8)) * **commpv2:** Curio CommPv2 compatibility ([FilOzone#156](FilOzone#156)) ([d529e0b](FilOzone@d529e0b)) * EIP712 signing support for metadata in CreateDataSet and AddPices ([FilOzone#173](FilOzone#173)) ([f396e0d](FilOzone@f396e0d)) * major rename - pandora->warm storage, proof sets->data sets, roots->pieces ([6e1a743](FilOzone@6e1a743)) * sp registry ([e680f82](FilOzone@e680f82)) * **utils:** split client and provider functionality to make setup easier ([66c9d02](FilOzone@66c9d02)) * **warmstorage:** discover dependent contract addresses from WarmStorage ([984966b](FilOzone@984966b)) ### Bug Fixes * ignore deleted providers when searching for retrieval options ([FilOzone#159](FilOzone#159)) ([2b8c427](FilOzone@2b8c427)) * **pdp:** encode the metadata correctly in extraData ([c4aea98](FilOzone@c4aea98)) * **pdp:** isComplete on data set creation should include server status ([FilOzone#158](FilOzone#158)) ([5cf3dc1](FilOzone@5cf3dc1)) * trim trailing slash from serviceURL ([cf8be53](FilOzone@cf8be53)) * **warmstorage:** adapt to view contract using extsload ([f56f00e](FilOzone@f56f00e)) ### Trivial Changes * add biome and git hooks ([FilOzone#165](FilOzone#165)) ([425ba99](FilOzone@425ba99)) * change imports to .ts ([FilOzone#185](FilOzone#185)) ([778f779](FilOzone@778f779)) * **deps-dev:** bump chai from 5.3.3 to 6.0.1 ([FilOzone#164](FilOzone#164)) ([6d64b0b](FilOzone@6d64b0b)) * **deps:** bump actions/setup-node from 4.4.0 to 5.0.0 ([FilOzone#190](FilOzone#190)) ([b43d391](FilOzone@b43d391)) * FilCDNBeneficiary ([FilOzone#191](FilOzone#191)) ([b394840](FilOzone@b394840)) * fix biome warnings ([FilOzone#170](FilOzone#170)) ([6d62d88](FilOzone@6d62d88)) * remove simple-git-hooks from devDeps ([d600d5e](FilOzone@d600d5e)) * update ABI imports and clean up unused code ([FilOzone#187](FilOzone#187)) ([6bdd507](FilOzone@6bdd507)) * update contract addresses ([2227cc9](FilOzone@2227cc9)) * update for alpha release contracts ([4a60150](FilOzone@4a60150)) * update TypeScript configuration ([FilOzone#172](FilOzone#172)) ([0e521d1](FilOzone@0e521d1))

Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.8.3 to 5.9.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release-publish.yml) - [Commits](microsoft/TypeScript@v5.8.3...v5.9.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 5.9.2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

## [0.24.1](FilOzone/synapse-sdk@v0.24.0...v0.24.1) (2025-09-05) ### Trivial Changes * **deps-dev:** bump typescript from 5.8.3 to 5.9.2 ([FilOzone#193](FilOzone#193)) ([8892319](FilOzone@8892319))

FilOzone#195) The registry allows the provider to have a different payee to provider address so we can't match on it. But we can match on providerId because it can't change. Also allow for graceful fallback if we find data sets but none of them match a provider we can use - so we'll just make a new one.

## [0.24.2](FilOzone/synapse-sdk@v0.24.1...v0.24.2) (2025-09-06) ### Bug Fixes * **pdp:** select provider on ID, allow graceful fallback when no match ([FilOzone#195](FilOzone#195)) ([30d32af](FilOzone@30d32af))

snadrus · 2025-09-14T17:47:21Z

I've left server.ts (except class rename) to make multi-party changes easier.

rvagg and others added 17 commits August 14, 2025 16:20

feat(commp): transition to CommPv2

812c0af

Signed-off-by: Jakub Sztandera <[email protected]>

feat(commp): use "PieceCID" terminology, use v2 exclusively

fcd4e77

Almost all references to "CommP" are now gone. This includes exports.

chore: update contract addresses

bb53029

feat(commpv2): Curio CommPv2 compatibility (FilOzone#156)

35f028f

* feat(commpv2): Curio CommPv2 compatibility Ref: filecoin-project/curio#596 * chore: update contract addresses

fix(pdp): isComplete on data set creation should include server status (

ae1cbc5

FilOzone#158)

fix: ignore deleted providers when searching for retrieval options (F…

f6fe683

…ilOzone#159)

feat: EIP712 signing support for metadata in CreateDataSet and AddPic…

b2fc68e

…es (FilOzone#173) Integrate KV metadata with Synapse Signed-off-by: Jakub Sztandera <[email protected]>

fix!(warmstorage): adapt to view contract using extsload

fc1ee0f

Ref: FilOzone/filecoin-services#144

feat(warmstorage): discover dependent contract addresses from WarmSto…

5de094c

…rage

fix(pdp): encode the metadata correctly in extraData

8a4b99f

Signed-off-by: Jakub Sztandera <[email protected]>

so far

fa24d8e

github-project-automation bot moved this to 📌 Triage in FS Sep 8, 2025

github-project-automation bot added this to FS Sep 8, 2025

rjan90 moved this from 📌 Triage to ⌨️ In Progress in FS Sep 9, 2025

rjan90 assigned snadrus Sep 10, 2025

wjmelements reviewed Sep 10, 2025

View reviewed changes

src/retriever/chain.ts Outdated Show resolved Hide resolved

snadrus marked this pull request as draft September 10, 2025 23:21

snadrus changed the title ~~Ajackson mk20pdp~~ Curio Market 2.0 - PDPv1 via @curio/market-client Sep 10, 2025

rvagg reviewed Sep 11, 2025

View reviewed changes

src/pdp/server.ts Show resolved Hide resolved

rvagg reviewed Sep 11, 2025

View reviewed changes

src/pdp/server.ts Show resolved Hide resolved

rvagg reviewed Sep 11, 2025

View reviewed changes

rvagg and others added 18 commits September 14, 2025 11:47

feat: sp registry

7315d5c

chore: change imports to .ts (FilOzone#185)

808b5dd

chore: remove simple-git-hooks from devDeps

e617459

Ref: FilOzone#165 (review) was accidentally added originally

chore: update for alpha release contracts

add2f2f

Fixes: FilOzone#157

feat(utils): split client and provider functionality to make setup ea…

17b921c

…sier

0.24.0-dev2

56b3451

fix: trim trailing slash from serviceURL

82f7a0a

chore: update ABI imports and clean up unused code (FilOzone#187)

8b2e555

chore: FilCDNBeneficiary (FilOzone#191)

b8ca45b

* filCDNBeneficiaryAddress * fix test * fix checksum address

chore(release): 0.24.1 [skip ci]

ea322a2

## [0.24.1](FilOzone/synapse-sdk@v0.24.0...v0.24.1) (2025-09-05) ### Trivial Changes * **deps-dev:** bump typescript from 5.8.3 to 5.9.2 ([FilOzone#193](FilOzone#193)) ([8892319](FilOzone@8892319))

chore(release): 0.24.2 [skip ci]

c914806

## [0.24.2](FilOzone/synapse-sdk@v0.24.1...v0.24.2) (2025-09-06) ### Bug Fixes * **pdp:** select provider on ID, allow graceful fallback when no match ([FilOzone#195](FilOzone#195)) ([30d32af](FilOzone@30d32af))

so far

ef8e147

name changes

14fbe61

Merge branch 'master' into ajackson-mk20pdp

fea4b77

snadrus added 2 commits September 14, 2025 12:55

server selection updates

49b147c

rough

e18cbe2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Curio Market 2.0 - PDPv1 via @curio/market-client #200

Curio Market 2.0 - PDPv1 via @curio/market-client #200

Uh oh!

snadrus commented Sep 8, 2025

Uh oh!

rjan90 commented Sep 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

snadrus commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

rvagg Sep 11, 2025

Uh oh!

snadrus Sep 14, 2025

Uh oh!

rvagg Sep 11, 2025

Uh oh!

snadrus Sep 14, 2025

Uh oh!

rvagg Sep 11, 2025

Uh oh!

snadrus Sep 14, 2025

Uh oh!

snadrus commented Sep 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

		@@ -0,0 +1,547 @@
		/**
		* PDPServer - Consolidated interface for all PDP server (Curio) HTTP operations

Curio Market 2.0 - PDPv1 via @curio/market-client #200

Are you sure you want to change the base?

Curio Market 2.0 - PDPv1 via @curio/market-client #200

Uh oh!

Conversation

snadrus commented Sep 8, 2025

Uh oh!

rjan90 commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

snadrus commented Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

rvagg Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

snadrus Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

rvagg Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

snadrus Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

rvagg Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

snadrus Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

snadrus commented Sep 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rjan90 commented Sep 9, 2025 •

edited

Loading