Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/synapse-sdk/src/pdp/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
validateDataSetCreationStatusResponse,
validateFindPieceResponse,
validatePieceAdditionStatusResponse,
validatePieceDeleteResponse,
} from './validation.ts'

/**
Expand Down Expand Up @@ -577,6 +578,35 @@ export class PDPServer {
return converted
}

/**
* Delete a piece from a data set
* @param dataSetId - The ID of dataset to delete
* @param clientDataSetId - Client dataset ID of the dataset to delete
* @param pieceID - The ID of the piece to delete
* @returns Promise for transaction hash of the delete operation
*/
async deletePiece(dataSetId: number, clientDataSetId: number, pieceID: number): Promise<string> {
const authData = await this.getAuthHelper().signSchedulePieceRemovals(clientDataSetId, [pieceID])
const payload = {
extraData: `0x${authData.signature}`,
}

const response = await fetch(`${this._serviceURL}/pdp/data-sets/${dataSetId}/pieces/${pieceID}`, {
method: 'DELETE',
headers: {
'Content-Type': 'application/json',
},
body: JSON.stringify(payload),
})

if (response.status !== 200) {
const errorText = await response.text()
throw new Error(`Failed to delete piece: ${response.status} ${response.statusText} - ${errorText}`)
}
const data = await response.json()
return validatePieceDeleteResponse(data).txHash
}

/**
* Encode DataSetCreateData for extraData field
* This matches the Solidity struct DataSetCreateData in Warm Storage contract
Expand Down
16 changes: 16 additions & 0 deletions packages/synapse-sdk/src/pdp/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,22 @@ export function validateDataSetCreationStatusResponse(value: unknown): DataSetCr
return value
}

export function validatePieceDeleteResponse(value: unknown): { txHash: string } {
if (typeof value !== 'object' || value == null) {
throw new Error('Invalid piece delete response format')
}

const obj = value as Record<string, unknown>

if (typeof obj.txHash !== 'string') {
throw new Error('Invalid piece delete response format')
}

return {
txHash: obj.txHash,
}
}

/**
* Validates and returns a PieceAdditionStatusResponse
* @param value - The value to validate
Expand Down
26 changes: 26 additions & 0 deletions packages/synapse-sdk/src/storage/context.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1260,6 +1260,32 @@ export class StorageContext {
return dataSetData.pieces.map((piece) => piece.pieceCid)
}

async _getPieceIdByCID(pieceCID: string | PieceCID): Promise<number> {
const parsedPieceCID = asPieceCID(pieceCID)
if (parsedPieceCID == null) {
throw createError('StorageContext', 'deletePiece', 'Invalid PieceCID provided')
}

const dataSetData = await this._pdpServer.getDataSet(this._dataSetId)
const pieceData = dataSetData.pieces.find((piece) => piece.pieceCid.toString() === parsedPieceCID.toString())
if (pieceData == null) {
throw createError('StorageContext', 'deletePiece', 'Piece not found in data set')
}
return pieceData.pieceId
}

/**
* Delete a piece with given CID from this data set
* @param piece - The PieceCID identifier or a piece number to delete by pieceID
* @returns Transaction hash of the delete operation
*/
async deletePiece(piece: string | PieceCID | number): Promise<string> {
const pieceId = typeof piece === 'number' ? piece : await this._getPieceIdByCID(piece)
const dataSetInfo = await this._warmStorageService.getDataSet(this._dataSetId)

return this._pdpServer.deletePiece(this._dataSetId, dataSetInfo.clientDataSetId, pieceId)
}

/**
* Check if a piece exists on this service provider.
* @param pieceCid - The PieceCID (piece CID) to check
Expand Down
38 changes: 38 additions & 0 deletions packages/synapse-sdk/src/test/pdp-server.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,44 @@ describe('PDPServer', () => {
})
})

describe('deletePiece', () => {
it('should handle successful delete', async () => {
const mockTxHash = '0x1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef'
const mockResponse = {
txHash: mockTxHash,
}
server.use(
// check that extraData is included
http.delete('http://pdp.local/pdp/data-sets/1/pieces/2', async ({ request }) => {
const body = await request.json()
assert.hasAllKeys(body, ['extraData'])
return HttpResponse.json(mockResponse, {
status: 200,
})
})
)
const result = await pdpServer.deletePiece(1, 0, 2)
assert.strictEqual(result, mockTxHash)
})

it('should handle server errors', async () => {
server.use(
http.delete('http://pdp.local/pdp/data-sets/1/pieces/2', async () => {
return HttpResponse.text('Database error', {
status: 500,
})
})
)
try {
await pdpServer.deletePiece(1, 0, 2)
assert.fail('Should have thrown error for server error')
} catch (error: any) {
assert.include(error.message, 'Failed to delete piece')
assert.include(error.message, '500')
}
})
})

describe('getDataSetCreationStatus', () => {
it('should handle successful status check', async () => {
const mockTxHash = '0x1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef'
Expand Down