fix: getPDPService always returns a pdpOffering

[wjmelements]

Reviewer @rvagg
See also FilOzone/filecoin-services#295
Neither of these issues were caught before because we currently catch all exceptions in SPRegistryService.getPDPService, a bad policy.
I don't remove the catch-all because there are more problems after this; for example, 'should select a random provider when no providerId specified' will fail when trying to create the data set.

Changes

• fix mock contract return typing
• fix outdated mocking for test that was only working because of the type error

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	synapse-dev	7f8e8c3	Commit Preview URL Branch Preview URL	Oct 17 2025, 09:25 PM

[wjmelements]

Astro build errors look unrelated:

11:09:50 PM [vite] (ssr) Error when evaluating SSR module /home/runner/work/synapse-sdk/synapse-sdk/docs/astro.config.mjs: localStorage.getItem is not a function
      at Object.<anonymous> (/home/runner/work/synapse-sdk/synapse-sdk/node_modules/.pnpm/@[email protected][email protected]/node_modules/@typescript/vfs/dist/vfs.cjs.production.min.js:1:407)
      at Module._compile (node:internal/modules/cjs/loader:1759:14)
      at Object..js (node:internal/modules/cjs/loader:1892:10)
      at Module.load (node:internal/modules/cjs/loader:1479:32)
      at Module._load (node:internal/modules/cjs/loader:1298:12)
      at TracingChannel.traceSync (node:diagnostics_channel:328:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:244:24)
      at Module.require (node:internal/modules/cjs/loader:1502:12)
      at require (node:internal/modules/helpers:152:16)
      at Object.<anonymous> (/home/runner/work/synapse-sdk/synapse-sdk/node_modules/.pnpm/@[email protected][email protected]/node_modules/@typescript/vfs/dist/index.js:5:20)
[astro] Unable to load your Astro config

[wjmelements]

Astro build errors look unrelated:

11:09:50 PM [vite] (ssr) Error when evaluating SSR module /home/runner/work/synapse-sdk/synapse-sdk/docs/astro.config.mjs: localStorage.getItem is not a function
      at Object.<anonymous> (/home/runner/work/synapse-sdk/synapse-sdk/node_modules/.pnpm/@[email protected][email protected]/node_modules/@typescript/vfs/dist/vfs.cjs.production.min.js:1:407)
      at Module._compile (node:internal/modules/cjs/loader:1759:14)
      at Object..js (node:internal/modules/cjs/loader:1892:10)
      at Module.load (node:internal/modules/cjs/loader:1479:32)
      at Module._load (node:internal/modules/cjs/loader:1298:12)
      at TracingChannel.traceSync (node:diagnostics_channel:328:14)
      at wrapModuleLoad (node:internal/modules/cjs/loader:244:24)
      at Module.require (node:internal/modules/cjs/loader:1502:12)
      at require (node:internal/modules/helpers:152:16)
      at Object.<anonymous> (/home/runner/work/synapse-sdk/synapse-sdk/node_modules/.pnpm/@[email protected][email protected]/node_modules/@typescript/vfs/dist/index.js:5:20)
[astro] Unable to load your Astro config

It works locally.