-
Notifications
You must be signed in to change notification settings - Fork 15
[WIP] createContexts #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wjmelements
wants to merge
11
commits into
next
Choose a base branch
from
create-contexts
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+365
−75
Draft
[WIP] createContexts #325
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1e3a5b4
wip
wjmelements 46cb269
createWithSelectedProvider
wjmelements b32e85c
wip
wjmelements 87bb94c
use ADDRESSES.calibration.spRegistry
wjmelements 74b98f9
fix sp-registry-service-test mocking
wjmelements 9c7ba74
setupProviderRegistryMocks
wjmelements 2342ab1
mockServiceProviderRegistry
wjmelements e0c5a27
remove other getProviderProducts mocking
wjmelements 4bdb0eb
fix mockServiceProviderRegistry
wjmelements 74dfb55
mock createDataSet handler
wjmelements 32e108b
select by providerAddresses
wjmelements File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're exposting this, we're essentially exposing
ProviderSelectionResult
as a public type that someone might use. So we should look at this flow a little more critically.-1
to signal that a new dataSet needs to be made, but we could also just omit it for that case I think.isNewDataSet
that's not used anywhere. Let's remove that.isExisting
is only used for the callback, but also is now overloading our use of-1
indataSetId
, so we don't really need it now eitherHere's an interesting option, make it an "intent" for how we want the context to be:
Simple variation that's not to different to now:
But I think I like the explicit descriptiveness of an intent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to make this method private