Skip to content

feat(upload): add exponential backoff to retry logic #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Open

feat(upload): add exponential backoff to retry logic #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/synapse-sdk/src/storage/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,7 +1015,9 @@ export class StorageContext {

// Poll for piece to be "parked" (ready)
const maxWaitTime = TIMING_CONSTANTS.PIECE_PARKING_TIMEOUT_MS
const pollInterval = TIMING_CONSTANTS.PIECE_PARKING_POLL_INTERVAL_MS
const baseDelay = TIMING_CONSTANTS.PIECE_PARKING_POLL_INTERVAL_MS
const maxDelay = 10_000
let attempt = 0
const startTime = Date.now()
let pieceReady = false

Expand All @@ -1026,10 +1028,12 @@ export class StorageContext {
pieceReady = true
break
} catch {
// Piece not ready yet, wait and retry if we haven't exceeded timeout
if (Date.now() - startTime + pollInterval < maxWaitTime) {
await new Promise((resolve) => setTimeout(resolve, pollInterval))
}
attempt++
const backoff = Math.min(baseDelay * 2 ** attempt, maxDelay)
const jitter = Math.random() * backoff * 0.2
const delay = backoff + jitter
if (Date.now() - startTime + delay >= maxWaitTime) break
await new Promise((resolve) => setTimeout(resolve, delay))
}
}
performance.mark('synapse:findPiece-end')
Expand Down
Loading