feat: Endorsement Certificates #443

wjmelements · 2025-11-15T05:50:49Z

Co-authored by @Kubuxu
Reviewer @rvagg @hugomrdias

Context

prefer to use at least one endorsed SP by default

For #312, when we are selecting the providers, we prefer that at least one provider has a prime endorsement.
If there aren't any prime endorsements, we do not panic.
We will surface these endorsements as product capabilities in the service provider registry.

Changes

define EIP712 type struct and domain for Endorsement Certificates
sign, encode, and decode endorsement certificates as product capabilities
selectProviderWithPing returns null on failure instead of throwing an exception
update createContext and createContexts to preferEndorsements in smartSelectProvider if no other providers have been selected
provide minimum script for signing endorsement certificates

ref: FIL-13, FIL-14

Signed-off-by: Jakub Sztandera <[email protected]>

…ugh-certs

cloudflare-workers-and-pages · 2025-11-15T05:50:58Z

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	synapse-dev	`72047d7`	Commit Preview URL Branch Preview URL	Nov 26 2025, 07:50 PM

packages/synapse-sdk/src/test/synapse.test.ts

wjmelements · 2025-11-15T06:07:10Z

packages/synapse-core/src/utils/cert.ts

+    notAfter: bytesToBigInt(data.slice(8, 16)),
+    signature: bytesToHex(data.slice(16)),
+  }
+  const address = await recoverTypedDataAddress({


I looked into why this was async (in principle it should not be). It is only because of this async import:

export async function recoverPublicKey({ hash, signature, }: RecoverPublicKeyParameters): Promise<RecoverPublicKeyReturnType> { const hashHex = isHex(hash) ? hash : toHex(hash) const { secp256k1 } = await import('@noble/curves/secp256k1')

oh, that's nasty, but oh well

packages/synapse-core/src/utils/cert.ts

Signed-off-by: Jakub Sztandera <[email protected]>

Co-authored-by: Jakub Sztandera <[email protected]>

packages/synapse-core/src/utils/cert.ts

Co-authored-by: Rod Vagg <[email protected]>

wjmelements · 2025-11-17T19:22:57Z

PRIME_ENDORSEMENTS

I think this belongs in constants.ts

The reason not to move this is that it would then be exported, and I don't think we intend to export it. if you want to export it I can make the change.

export * from './constants.ts'

@rvagg @hugomrdias let me know if you agree

hugomrdias · 2025-11-25T11:36:18Z

packages/synapse-core/src/utils/cert.ts

+  if (hexData.length !== 164) {
+    return {
+      address: null,
+      endorsement: {
+        nonce: 0n,
+        notAfter: 0n,
+        signature: '0x',
+      },
+    }
+  }


why not just throw err?

I want to reduce use of try/catch for expected situations because it can mask unexpected situations

packages/synapse-core/src/utils/cert.ts

hugomrdias · 2025-11-25T11:39:06Z

packages/synapse-core/tools/endorse-sp.js

can you pls move this to examples/cli and make a command for this

all of those commands in cli are only using calibration. None of them consult env. How do you want those to select the chain?

ah yes will fix !

@hugomrdias are we blocked on that? should we land this in place and then move it later or do we need to resolve #469 first?

i just dont like random cli files in the core folder we have the utils folder for that and now the examples/cli for more structured cli/nodejs stuff.

but yes we can land this and fix later

wjmelements · 2025-11-25T19:09:58Z

packages/synapse-core/tools/endorse-sp.js

+      notAfter: EXPIRY,
+    })
+    console.log('Provider:', providerId)
+    console.log('Endorsement:', encoded)


TODO: curio interface for hex

filecoin-project/curio#816

wjmelements · 2025-11-25T19:18:45Z

packages/synapse-core/tools/endorse-sp.js

+
+const PRIVATE_KEY = process.env.PRIVATE_KEY
+const ETH_RPC_URL = process.env.ETH_RPC_URL || 'https://api.calibration.node.glif.io/rpc/v1'
+const EXPIRY = process.env.EXPIRY || BigInt(Math.floor(Date.now() / 1000)) + 10368000n


comment that this is (now + 4 months)

wjmelements · 2025-11-25T19:19:21Z

packages/synapse-core/tools/endorse-sp.js

+}
+
+const PRIVATE_KEY = process.env.PRIVATE_KEY
+const ETH_RPC_URL = process.env.ETH_RPC_URL || 'https://api.calibration.node.glif.io/rpc/v1'


maybe these should be ??

not strictly necessary but would provide clearer error cases - if you set ETH_RPC_URL to something falsy then it's going to use the default where it probably should error, e.g. "can't connect to RPC provider '0'

wjmelements · 2025-11-25T19:20:52Z

packages/synapse-core/src/utils/cert.ts

+      }
+    } catch {
+      // Skip invalid endorsements
+    }


I think we can remove this catch now

Would need to make sure that signatures that fail to recover don't throw. Should have a test case covering this in case that behavior changes.

👍 looks to me like a failure here would be of the fatal kind now since you're doing so much in decodeEndorsement

…rtificates

rvagg · 2025-12-01T10:33:37Z

packages/synapse-core/src/utils/cert.ts

+  const signature = await signTypedData(client, {
+    account: client.account,
+    domain: {
+      name: 'Storage Endorsement',


should be a const

rvagg · 2025-12-01T10:41:37Z

packages/synapse-sdk/src/storage/context.ts

+        (results: [ProviderInfo[], ProviderInfo[]], provider: ProviderInfo) => {
+          results[
+            preferEndorsements.some(
+              (endorsement: Address) => endorsement in (provider.products.PDP?.data.endorsements ?? {})


could be cleaned up by pulling provider.products.PDP?.data.endorsements ?? {} into a local variable inside the arrow func, then we might be able to avoid the multi-line mess that's making this hard to read

rvagg · 2025-12-01T10:44:01Z

Overall fine by me, just a few minor suggestions in there and one major concern to be resolved regarding the CLI tool.
We also need that Curio change dealt with to make this useful.
I think one of us can pick this up this week so it doesn't rest on William, who has much more important things to attend to now!

linear · 2025-12-01T22:48:13Z

FIL-14 Synapse has tooling for "endorsing" an SP

rvagg

Blocked by decision @ #540
Comes down to resourcing, do we spend the time to implement an alternative and can we afford the time for that.

wjmelements · 2026-01-08T06:13:03Z

Blocked by decision @ #540 Comes down to resourcing, do we spend the time to implement an alternative and can we afford the time for that.

Much of this work can be reused with the Endorsement Registry approach.

Kubuxu and others added 14 commits November 12, 2025 18:59

Baseline super-good-enough cert

6be6998

Signed-off-by: Jakub Sztandera <[email protected]>

stub decodeEndorsements

374acc3

preferEndorsements

5a4ec65

start decoding endorsements

8ce3807

Signed-off-by: Jakub Sztandera <[email protected]>

notAfter as timesetamp

ea1c8f8

encodeEndorsements

b2538d1

mv cert.ts to utils

174a7e8

utils export from cert.ts

0959768

fix test

8fdb6bf

test that createContexts prefers endorsements

67af7c0

encode/decode certs with domain separator

a34808c

add cert test

953f4c8

Merge remote-tracking branch 'origin/master' into feat/super-good-eno…

c4ea7c7

…ugh-certs

add tools/endorse-sp.js

e5236ad

wjmelements requested a review from hugomrdias November 15, 2025 05:50

github-project-automation bot added this to FS Nov 15, 2025

wjmelements requested a review from rvagg November 15, 2025 05:50

github-project-automation bot moved this to 📌 Triage in FS Nov 15, 2025

wjmelements added the enhancement New feature or request label Nov 15, 2025

wjmelements commented Nov 15, 2025

View reviewed changes

packages/synapse-sdk/src/test/synapse.test.ts Outdated Show resolved Hide resolved

wjmelements commented Nov 15, 2025

View reviewed changes

packages/synapse-sdk/src/test/synapse.test.ts Outdated Show resolved Hide resolved

increase timeout for CI

ebebd81

wjmelements commented Nov 15, 2025

View reviewed changes

Kubuxu reviewed Nov 15, 2025

View reviewed changes

packages/synapse-core/src/utils/cert.ts Outdated Show resolved Hide resolved

Kubuxu and others added 3 commits November 15, 2025 16:26

make the decodeEndorsements a bit simpler

344d9d2

Signed-off-by: Jakub Sztandera <[email protected]>

add more tests

c81971a

Signed-off-by: Jakub Sztandera <[email protected]>

Update packages/synapse-core/src/utils/cert.ts

7c784b7

Co-authored-by: Jakub Sztandera <[email protected]>

rvagg reviewed Nov 16, 2025

View reviewed changes

packages/synapse-core/src/utils/cert.ts Outdated Show resolved Hide resolved

rvagg reviewed Nov 16, 2025

View reviewed changes

packages/synapse-core/src/utils/cert.ts Outdated Show resolved Hide resolved

wjmelements and others added 3 commits November 17, 2025 13:15

Update packages/synapse-core/src/utils/cert.ts

7c58dd8

Co-authored-by: Rod Vagg <[email protected]>

cleanup

6874d4a

Update packages/synapse-core/src/utils/cert.ts

77a4524

Co-authored-by: Rod Vagg <[email protected]>

wjmelements requested a review from rvagg November 17, 2025 19:25

hugomrdias requested changes Nov 25, 2025

View reviewed changes

github-project-automation bot moved this from 📌 Triage to ⌨️ In Progress in FS Nov 25, 2025

wjmelements commented Nov 25, 2025

View reviewed changes

wjmelements added 2 commits November 25, 2025 13:57

Merge remote-tracking branch 'origin/master' into feat/endorsement-ce…

1318554

…rtificates

disallow undefined chainId in decodeEndorsement

f1a66ef

wjmelements mentioned this pull request Nov 25, 2025

feat!(ServiceProviderRegistry): Hex Capabilities filecoin-project/curio#816

Merged

accept any of the preferred endorsements

72047d7

rvagg reviewed Dec 1, 2025

View reviewed changes

rvagg mentioned this pull request Dec 1, 2025

fix: enable ledger signing to endorse-sp.js #471

Closed

BigLep mentioned this pull request Dec 2, 2025

[Project] GA durability (2 copies; 1 with endorsed SP) FilOzone/filecoin-services#357

Open

13 tasks

rjan90 added this to the M4: Filecoin Service Liftoff milestone Dec 3, 2025

rvagg mentioned this pull request Dec 9, 2025

Simplify provider & data set resolution logic & API #495

Open

BigLep moved this from ⌨️ In Progress to 🐱 Todo in FS Dec 17, 2025

rvagg mentioned this pull request Jan 8, 2026

Decision: Endorsement Certificates vs Smart Contract Approach #540

Open

rvagg requested changes Jan 8, 2026

View reviewed changes

github-project-automation bot moved this from 🐱 Todo to ⌨️ In Progress in FS Jan 8, 2026

rvagg mentioned this pull request Jan 12, 2026

Endorsed Providers Contract FilOzone/filecoin-services#382

Open

rjan90 assigned wjmelements Jan 12, 2026

feat: Endorsement Certificates #443

Are you sure you want to change the base?

feat: Endorsement Certificates #443

Uh oh!

Conversation

wjmelements commented Nov 15, 2025 • edited by BigLep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Changes

Uh oh!

cloudflare-workers-and-pages bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Workers

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wjmelements commented Nov 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugomrdias Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wjmelements Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rvagg commented Dec 1, 2025

Uh oh!

linear bot commented Dec 1, 2025

Uh oh!

rvagg left a comment

Choose a reason for hiding this comment

Uh oh!

wjmelements commented Jan 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wjmelements commented Nov 15, 2025 •

edited by BigLep

Loading

cloudflare-workers-and-pages bot commented Nov 15, 2025 •

edited

Loading

hugomrdias Dec 3, 2025 •

edited

Loading

wjmelements Nov 26, 2025 •

edited

Loading