FF-219 Implemented dummy Responses for ShowContents. (#50)

* Implemented dummy Responses for ShowContents.

* Fixed Pipeline

* Fixed a bug with wrong paths, added one more layer.

Author: open-schnick

.run/Run Tests with Coverage.run.xml

@@ -11,7 +11,7 @@
           <option name="goals">
             <list>
               <option value="clean" />
-              <option value="test" />
+              <option value="verify" />
             </list>
           </option>
           <option name="pomFileName" value="pom.xml" />

pom.xml

@@ -171,8 +171,10 @@
                                     </includes>
                                     <excludes>
                                         <!-- NOT IMPLEMENTED YET -->
+                                        <!-- TODO: remove fs -->
                                         <exclude>*FileSystemRestService</exclude>
                                         <exclude>*PermissionRestService</exclude>
+                                        <exclude>*FileSystemBusinessService</exclude>
                                     </excludes>
                                     <limits>
                                         <limit>

src/main/java/de/filefighter/rest/domain/filesystem/business/FileSystemBusinessService.java

@@ -1,7 +1,60 @@
 package de.filefighter.rest.domain.filesystem.business;
 
+import de.filefighter.rest.domain.filesystem.data.dto.File;
+import de.filefighter.rest.domain.filesystem.data.dto.Folder;
+import de.filefighter.rest.domain.filesystem.data.dto.FolderContents;
+import de.filefighter.rest.domain.filesystem.exceptions.FileSystemContentsNotAccessibleException;
+import de.filefighter.rest.domain.filesystem.type.FileSystemType;
+import de.filefighter.rest.domain.user.data.dto.User;
 import org.springframework.stereotype.Service;
 
+import java.time.Instant;
+
 @Service
 public class FileSystemBusinessService {
+
+    public FileSystemBusinessService() {
+
+    }
+
+    public static FolderContents getContentsOfFolder(String path, User authenticatedUser) {
+        FolderContents folderContents;
+        switch (path) {
+            case "/":
+                folderContents = FolderContents.builder()
+                        .files(new File[]{new File(0, "DummyFileInRoot.txt", 420, 0, Instant.now().getEpochSecond(), FileSystemType.TEXT, null)})
+                        .folders(new Folder[]{
+                                new Folder(1, "/bla", "bla", 12345, 0, Instant.now().getEpochSecond(), null),
+                                new Folder(2, "/fasel", "fasel", 12345, 0, Instant.now().getEpochSecond(), null)
+                        })
+                        .build();
+                break;
+            case "/bla":
+                folderContents = FolderContents.builder()
+                        .files(new File[]{
+                                new File(3, "DummyFileInBla.pdf", 42, 0, Instant.now().getEpochSecond(), FileSystemType.PDF, null),
+                                new File(4, "DummyFileInBla1.jpg", 1234321, 0, Instant.now().getEpochSecond(), FileSystemType.PICTURE, null)
+                        })
+                        .build();
+                break;
+            case "/fasel":
+                folderContents = FolderContents.builder()
+                        .files(new File[]{new File(5, "DummyFileInFasel.txt", 420, 0, Instant.now().getEpochSecond(), FileSystemType.TEXT, null)})
+                        .folders(new Folder[]{new Folder(6, "/fasel/johndoessecretchamber", "JohnDoesSecretChamber", 12345, 0, Instant.now().getEpochSecond(), null)})
+                        .build();
+                break;
+            case "/fasel/johndoessecretchamber":
+                folderContents = FolderContents.builder()
+                        .folders(new Folder[]{new Folder(7, "/fasel/johndoessecretchamber/empty", "Empty", 12345, 0, Instant.now().getEpochSecond(), null)})
+                        .build();
+                break;
+            case "/fasel/johndoessecretchamber/empty":
+                folderContents = FolderContents.builder().build();
+                break;
+            default:
+                throw new FileSystemContentsNotAccessibleException();
+
+        }
+        return folderContents;
+    }
 }

src/main/java/de/filefighter/rest/domain/filesystem/data/dto/Folder.java

@@ -9,8 +9,8 @@ public class Folder extends FileSystemItem {
     public Folder() {
     }
 
-    public Folder(long fileSystemId, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet, String path) {
-        super(fileSystemId, name, size, createdByUserId, lastUpdated, type, permissionSet);
+    public Folder(long id, String path, String name, double size, long createdByUserId, long lastUpdated, PermissionSet permissionSet) {
+        super(id, name, size, createdByUserId, lastUpdated, FileSystemType.FOLDER, permissionSet);
         this.path = path;
     }
 

src/main/java/de/filefighter/rest/domain/filesystem/exceptions/FileSystemContentsNotAccessibleAdvise.java

@@ -0,0 +1,22 @@
+package de.filefighter.rest.domain.filesystem.exceptions;
+
+import de.filefighter.rest.rest.ServerResponse;
+import org.slf4j.LoggerFactory;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.ControllerAdvice;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.ResponseBody;
+import org.springframework.web.bind.annotation.ResponseStatus;
+
+@ControllerAdvice
+public class FileSystemContentsNotAccessibleAdvise {
+
+    @ResponseBody
+    @ExceptionHandler(FileSystemContentsNotAccessibleException.class)
+    @ResponseStatus(HttpStatus.BAD_REQUEST)
+    ResponseEntity<ServerResponse> fileSystemContentsNotAccessibleAdvise(FileSystemContentsNotAccessibleException ex) {
+        LoggerFactory.getLogger(FileSystemContentsNotAccessibleException.class).warn(ex.getMessage());
+        return new ResponseEntity<>(new ServerResponse(HttpStatus.BAD_REQUEST, ex.getMessage()), HttpStatus.BAD_REQUEST);
+    }
+}

src/main/java/de/filefighter/rest/domain/filesystem/exceptions/FileSystemContentsNotAccessibleException.java

@@ -0,0 +1,8 @@
+package de.filefighter.rest.domain.filesystem.exceptions;
+
+public class FileSystemContentsNotAccessibleException extends RuntimeException {
+
+    public FileSystemContentsNotAccessibleException() {
+        super("Folder does not exist, or you are not allowed to see the folder.");
+    }
+}

src/main/java/de/filefighter/rest/domain/filesystem/rest/FileSystemRestController.java

@@ -32,7 +32,7 @@ public ResponseEntity<FolderContents> getContentsOfFolder(
     ) {
 
         LOG.info("Requested Folder contents of folder with path {}.", path);
-        return fileSystemRestService.getContentsOfFolderByIdAndAccessToken(path, accessToken);
+        return fileSystemRestService.getContentsOfFolderByPathAndAccessToken(path, accessToken);
     }
 
     @GetMapping(FS_BASE_URI + "{fsItemId}/info")

src/main/java/de/filefighter/rest/domain/filesystem/rest/FileSystemRestService.java

@@ -1,18 +1,44 @@
 package de.filefighter.rest.domain.filesystem.rest;
 
+import de.filefighter.rest.configuration.RestConfiguration;
+import de.filefighter.rest.domain.common.InputSanitizerService;
+import de.filefighter.rest.domain.filesystem.business.FileSystemBusinessService;
 import de.filefighter.rest.domain.filesystem.data.dto.FileSystemItem;
 import de.filefighter.rest.domain.filesystem.data.dto.FileSystemItemUpdate;
 import de.filefighter.rest.domain.filesystem.data.dto.FolderContents;
+import de.filefighter.rest.domain.token.business.AccessTokenBusinessService;
+import de.filefighter.rest.domain.token.data.dto.AccessToken;
+import de.filefighter.rest.domain.user.business.UserAuthorizationService;
+import de.filefighter.rest.domain.user.data.dto.User;
 import de.filefighter.rest.rest.ServerResponse;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.stereotype.Service;
 
 @Service
 public class FileSystemRestService implements FileSystemRestServiceInterface {
 
+    private final UserAuthorizationService userAuthorizationService;
+    private final InputSanitizerService inputSanitizerService;
+    private final AccessTokenBusinessService accessTokenBusinessService;
+    private final FileSystemBusinessService fileSystemBusinessService;
+
+    public FileSystemRestService(UserAuthorizationService userAuthorizationService, InputSanitizerService inputSanitizerService, AccessTokenBusinessService accessTokenBusinessService, FileSystemBusinessService fileSystemBusinessService) {
+        this.userAuthorizationService = userAuthorizationService;
+        this.inputSanitizerService = inputSanitizerService;
+        this.accessTokenBusinessService = accessTokenBusinessService;
+        this.fileSystemBusinessService = fileSystemBusinessService;
+    }
+
     @Override
-    public ResponseEntity<FolderContents> getContentsOfFolderByIdAndAccessToken(String path, String accessToken) {
-        return null;
+    public ResponseEntity<FolderContents> getContentsOfFolderByPathAndAccessToken(String path, String accessTokenValue) {
+        String cleanHeader = inputSanitizerService.sanitizeRequestHeader(RestConfiguration.AUTHORIZATION_BEARER_PREFIX, accessTokenValue);
+        String cleanValue = inputSanitizerService.sanitizeTokenValue(cleanHeader);
+        AccessToken accessToken = accessTokenBusinessService.findAccessTokenByValue(cleanValue);
+        User authenticatedUser = userAuthorizationService.authenticateUserWithAccessToken(accessToken);
+
+        FolderContents folderContents = FileSystemBusinessService.getContentsOfFolder(path, authenticatedUser);
+        return new ResponseEntity<>(folderContents, HttpStatus.OK);
     }
 
     @Override

src/main/java/de/filefighter/rest/domain/filesystem/rest/FileSystemRestServiceInterface.java

@@ -7,7 +7,7 @@
 import org.springframework.http.ResponseEntity;
 
 public interface FileSystemRestServiceInterface {
-    ResponseEntity<FolderContents> getContentsOfFolderByIdAndAccessToken(String path, String accessToken);
+    ResponseEntity<FolderContents> getContentsOfFolderByPathAndAccessToken(String path, String accessToken);
     ResponseEntity<FileSystemItem> getInfoAboutFileOrFolderByIdAndAccessToken(long fsItemId, String accessToken);
     ResponseEntity<FileSystemItem> findFileOrFolderByNameAndAccessToken(String name, String accessToken);
     ResponseEntity<FileSystemItem> uploadFileSystemItemWithAccessToken(FileSystemItemUpdate fileSystemItemUpdate, String accessToken);

src/test/java/de/filefighter/rest/domain/filesystem/rest/FileSystemRestControllerUnitTest.java

@@ -33,7 +33,7 @@ void getContentsOfFolder() {
         String path= "/root/data.txt";
         String token = "token";
 
-        when(fileSystemRestServiceMock.getContentsOfFolderByIdAndAccessToken(path, token)).thenReturn(expectedModel);
+        when(fileSystemRestServiceMock.getContentsOfFolderByPathAndAccessToken(path, token)).thenReturn(expectedModel);
 
         ResponseEntity<FolderContents> actualModel = fileSystemRestController.getContentsOfFolder(path, token);
         assertEquals(expectedModel, actualModel);