Skip to content
This repository was archived by the owner on Apr 5, 2024. It is now read-only.

Commit b4b3e53

Browse files
authored
Refactoring...... and wasting time. (#49)
* TODO: write meaningful cogmmit message * Make Sure You Are Square With Your God Before Trying To Merge This
1 parent a1077a4 commit b4b3e53

23 files changed

+73
-72
lines changed

src/main/java/de/filefighter/rest/configuration/PrepareDataBase.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ CommandLineRunner initDataBaseProd(UserRepository userRepository, FileSystemRepo
8888
LOG.info("Preloading default fsStructure: {}.", fileSystemRepository.save(FileSystemEntity
8989
.builder()
9090
.createdByUserId(0)
91-
.id(0)
91+
.fileSystemId(0)
9292
.isFile(false)
9393
.path("/")
9494
.itemIds(new long[0])
@@ -145,7 +145,7 @@ CommandLineRunner initDataBaseDev(UserRepository userRepository, AccessTokenRepo
145145
LOG.info("Preloading default fsItems: {} {}.",
146146
fileSystemRepository.save(FileSystemEntity.builder()
147147
.createdByUserId(0)
148-
.id(0)
148+
.fileSystemId(0)
149149
.isFile(false)
150150
.path("/")
151151
.itemIds(new long[]{1})
@@ -157,7 +157,7 @@ CommandLineRunner initDataBaseDev(UserRepository userRepository, AccessTokenRepo
157157
.build()),
158158
fileSystemRepository.save(FileSystemEntity.builder()
159159
.createdByUserId(0)
160-
.id(1)
160+
.fileSystemId(1)
161161
.isFile(true)
162162
.lastUpdated(Instant.now().getEpochSecond())
163163
.name("dummyFile.txt")

src/main/java/de/filefighter/rest/domain/filesystem/data/dto/File.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ public class File extends FileSystemItem{
77
public File() {
88
}
99

10-
public File(long id, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet) {
11-
super(id, name, size, createdByUserId, lastUpdated, type, permissionSet);
10+
public File(long fileSystemId, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet) {
11+
super(fileSystemId, name, size, createdByUserId, lastUpdated, type, permissionSet);
1212
}
1313
}

src/main/java/de/filefighter/rest/domain/filesystem/data/dto/FileSystemItem.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
@Getter
99
@Setter
1010
public class FileSystemItem {
11-
private long id;
11+
private long fileSystemId;
1212
private String name;
1313
private double size;
1414
private long createdByUserId; //uploadedBy
@@ -19,8 +19,8 @@ public class FileSystemItem {
1919
protected FileSystemItem() {
2020
}
2121

22-
public FileSystemItem(long id, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet) {
23-
this.id = id;
22+
public FileSystemItem(long fileSystemId, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet) {
23+
this.fileSystemId = fileSystemId;
2424
this.name = name;
2525
this.size = size;
2626
this.createdByUserId = createdByUserId;

src/main/java/de/filefighter/rest/domain/filesystem/data/dto/Folder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ public class Folder extends FileSystemItem {
99
public Folder() {
1010
}
1111

12-
public Folder(long id, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet, String path) {
13-
super(id, name, size, createdByUserId, lastUpdated, type, permissionSet);
12+
public Folder(long fileSystemId, String name, double size, long createdByUserId, long lastUpdated, FileSystemType type, PermissionSet permissionSet, String path) {
13+
super(fileSystemId, name, size, createdByUserId, lastUpdated, type, permissionSet);
1414
this.path = path;
1515
}
1616

src/main/java/de/filefighter/rest/domain/filesystem/data/persistance/FileSystemEntity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class FileSystemEntity {
1212

1313
@MongoId
1414
private String mongoId;
15-
private long id;
15+
private long fileSystemId;
1616
private String name;
1717
private String path;
1818
private long typeId;

src/main/java/de/filefighter/rest/domain/filesystem/data/persistance/FileSystemRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
@Service
77
public interface FileSystemRepository extends MongoRepository<FileSystemEntity, String> {
8-
FileSystemEntity findById(long id);
8+
FileSystemEntity findByFileSystemId(long fileSystemId);
99
}

src/main/java/de/filefighter/rest/domain/token/business/AccessTokenBusinessService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public AccessTokenBusinessService(AccessTokenRepository accessTokenRepository, A
2929
}
3030

3131
public AccessToken getValidAccessTokenForUser(User user) {
32-
long userId = user.getId();
32+
long userId = user.getUserId();
3333
AccessTokenEntity accessTokenEntity = accessTokenRepository.findByUserId(userId);
3434
long currentTimeSeconds = Instant.now().getEpochSecond();
3535

src/main/java/de/filefighter/rest/domain/user/business/UserBusinessService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ public User getUserById(long userId) {
6262
}
6363

6464
public RefreshToken getRefreshTokenForUser(User user) {
65-
UserEntity userEntity = userRepository.findByUserIdAndUsername(user.getId(), user.getUsername());
65+
UserEntity userEntity = userRepository.findByUserIdAndUsername(user.getUserId(), user.getUsername());
6666
if (null == userEntity)
67-
throw new UserNotFoundException(user.getId());
67+
throw new UserNotFoundException(user.getUserId());
6868

6969
String refreshTokenValue = userEntity.getRefreshToken();
7070

@@ -157,7 +157,7 @@ public void updateUser(long userId, UserRegisterForm userToUpdate, User authenti
157157
throw new UserNotUpdatedException("Authenticated User is not allowed.");
158158

159159
boolean authenticatedUserIsAdmin = Arrays.stream(authenticatedUser.getGroups()).anyMatch(g -> g == Groups.ADMIN);
160-
if (userId != authenticatedUser.getId() && !authenticatedUserIsAdmin)
160+
if (userId != authenticatedUser.getUserId() && !authenticatedUserIsAdmin)
161161
throw new UserNotUpdatedException("Only Admins are allowed to update other users.");
162162

163163
UserEntity userEntityToUpdate = userRepository.findByUserId(userId);

src/main/java/de/filefighter/rest/domain/user/business/UserDtoService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,17 @@ public UserDtoService(GroupRepository groupRepository, UserRepository userReposi
2323
public User createDto(UserEntity entity) {
2424
return User
2525
.builder()
26-
.id(entity.getUserId())
26+
.userId(entity.getUserId())
2727
.username(entity.getUsername())
2828
.groups(groupRepository.getGroupsByIds(entity.getGroupIds()))
2929
.build();
3030
}
3131

3232
@Override
3333
public UserEntity findEntity(User dto) {
34-
UserEntity userEntity = userRepository.findByUserIdAndUsername(dto.getId(), dto.getUsername());
34+
UserEntity userEntity = userRepository.findByUserIdAndUsername(dto.getUserId(), dto.getUsername());
3535
if (null == userEntity)
36-
throw new UserNotFoundException(dto.getId());
36+
throw new UserNotFoundException(dto.getUserId());
3737

3838
return userEntity;
3939
}

src/main/java/de/filefighter/rest/domain/user/data/dto/User.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
@Data
88
@Builder
99
public class User {
10-
private long id;
10+
private long userId;
1111
private String username;
1212
private Groups[] groups;
1313

14-
public User(long id, String username, Groups... groups) {
15-
this.id = id;
14+
public User(long userId, String username, Groups... groups) {
15+
this.userId = userId;
1616
this.username = username;
1717
this.groups = groups;
1818
}

0 commit comments

Comments
 (0)