Skip to content

Commit 8eff71f

Browse files
committed
fix: make smoke tests run sequentially so changes on browser cookie is independent between tests
1 parent 35c8777 commit 8eff71f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

lib/smoke/smoke-test.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,15 @@ class SmokeTest {
109109

110110
try {
111111

112-
const allTests = [directly(15, puppetTests)];
113-
if (crossBrowserTests.length > 0) {
114-
allTests.push(directly(5, crossBrowserTests));
115-
} else {
116-
allTests.push(Promise.resolve([]));
112+
const puppetResults = [];
113+
const crossBrowserResults = [];
114+
for (let test of puppetTests) {
115+
puppetResults.push(await test());
116+
}
117+
for (let test of crossBrowserTests) {
118+
crossBrowserResults.push(await test());
117119
}
118120

119-
const [puppetResults, crossBrowserResults] = await Promise.all(allTests);
120121
const timeTaken = new Date(new Date().getTime() - startTime).toISOString().substr(14, 5);
121122

122123
return await this.displayResults(puppetResults, crossBrowserResults, timeTaken, puppetTests.length + crossBrowserTests.length);

0 commit comments

Comments
 (0)