Skip to content

Comments

[Fix] Image Service sources#2367

Open
Sqyphen wants to merge 10 commits intomainfrom
update/image_service_source_param_corrections
Open

[Fix] Image Service sources#2367
Sqyphen wants to merge 10 commits intomainfrom
update/image_service_source_param_corrections

Conversation

@Sqyphen
Copy link
Contributor

@Sqyphen Sqyphen commented Feb 18, 2026

[Fix]

Update all locations of Image Service sources with a valid source

@Sqyphen Sqyphen requested a review from a team as a code owner February 18, 2026 15:50
@joelcarr
Copy link
Member

Tests are currently failing due to a missing dependency in the website app. This is fixed in #2368.

@joelcarr joelcarr force-pushed the update/image_service_source_param_corrections branch from 82a37fd to 917970e Compare February 19, 2026 10:43
Copy link
Member

@j-mes j-mes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻‍♂️ Thank you for doing this @Sqyphen! A bit of a breather from the overlord @j-dav 🧌

@joelcarr
Copy link
Member

@Sqyphen Please can you update the tests to handle the new Image Service sources?

@Sqyphen
Copy link
Contributor Author

Sqyphen commented Feb 20, 2026

@joelcarr Yes, I'll look into that now.
Apologies, I was on AL yesterday

@Sqyphen Sqyphen requested a review from a team as a code owner February 20, 2026 08:50
@Sqyphen
Copy link
Contributor Author

Sqyphen commented Feb 20, 2026

@j-mes & @joelcarr
All done with tests passing 👍🏼

Copy link
Member

@joelcarr joelcarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@Sqyphen
Copy link
Contributor Author

Sqyphen commented Feb 20, 2026

@j-mes Can I merge this in or will you do so when you're ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants