re-add tenantinfo interface #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewTriesToCode
changed the title
atrauzzi
reviewed
Jan 7, 2026
| /// Information about the tenant for this context. | ||
| /// </summary> | ||
| TenantInfo? TenantInfo { get; init; } | ||
| ITenantInfo? TenantInfo { get; init; } |
There was a problem hiding this comment.
It likely doesn't concern any code I'd author, but do you need init here?
Contributor
Author
There was a problem hiding this comment.
agree, I have removed the initial accessors here
atrauzzi
approved these changes
Jan 7, 2026
atrauzzi
left a comment
atrauzzi
left a comment
There was a problem hiding this comment.
All in all, looks good. Just a comment on an init in an interface. Could probably broadly apply that question everywhere. But yeah, looking forward to this! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v10 a breaking change was the removal of
ITenantInfoandTenantInfochanged to a record in the name of immutability. Based on community feedback this is reverted.ITenantInfois back andTenantInfois a basic class implementation. This is technically a breaking change but will be treated as a fix for versioning.Closes #1073