This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Fix an issue where onAllComplete can be called multiple times per addFile() call #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…File() call. _getNotFinished, which is used to determine when to fire the onAllComplete callback, wasn't accounting for files in the UPLOAD_FINALIZING state. For smaller files, this could cause onAllComplete to be called multiple times per set of files passed to addFiles(). Note, the expected result is for onAllComplete() to be called only once per call to addFiles().
|
+1 Please merge This is pretty much critical, because as
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_getNotFinished, which is used to determine when to fire the onAllComplete callback, wasn't accounting for files in the UPLOAD_FINALIZING state. For smaller files, this could cause onAllComplete to be called multiple times per set of files passed to addFiles().
Note, the expected result is for onAllComplete() to be called only once per call to addFiles().