Skip to content

add oauth when jwt subject is available#18

Open
muhammadn wants to merge 3 commits intomainfrom
feat/add-oauth-when-available
Open

add oauth when jwt subject is available#18
muhammadn wants to merge 3 commits intomainfrom
feat/add-oauth-when-available

Conversation

@muhammadn
Copy link
Collaborator

@muhammadn muhammadn commented Jul 1, 2024

Describe your changes

  • Previously we remove including OAuth information as it always send oauth JWT Subject even though the user token does not exist, causing failure to send logging to firetail.

This PR adds it back and ensure that all keys with empty (nil) values are discarded.

  • Update critical vulnerability to rails example, not that important but still just to be safe.

Issue ticket number and link

Checklist before requesting a review

  • I have resolved any merge conflicts
  • I have run tests locally and they pass
  • I have linted and auto-formatted the code
  • If there is new or changed functionality, I have added/updated the tests
  • If there is new or changed functionality, I have added/updated the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants