-
Notifications
You must be signed in to change notification settings - Fork 222
Updated README for 'force' command #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e your bill, such as minimum instances required.
Co-authored-by: Bryan Kendall <[email protected]>
…port for channel site deployment with force flag. Updated tests to and types to account for force flags. Force flag is now optional on ProductionDeployConfig and ChannelDeployConfig. Simplified deploy calls using force flag to automatically append force based on the boolean value nad removed the force-specific branch in index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ThadCastl3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the README.md file to reflect the recent addition of a force command or flag. The changes provide clear documentation for this new functionality, including usage examples and a detailed description of its purpose, ensuring users understand how to leverage it within their configurations.
Highlights
- Documentation Update: Added commented-out examples for the
force: trueflag within two distinctjobsconfiguration sections, illustrating how to optionally use this new feature. - New Option Description: Included a new dedicated section under 'Options' that defines the
forceinput as a boolean type and clarifies its purpose: to bypass confirmation prompts.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the README.md to document the new force command option. The changes correctly add examples and a description for the new option. I've suggested one minor improvement to make the description of the force flag more detailed and consistent with action.yml for better user understanding.
README.md
Outdated
|
|
||
| ### `force` _{boolean}_ | ||
|
|
||
| Bypass the confirmation prompt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for the force flag could be more descriptive. The action.yml file has a more detailed explanation which would be beneficial here as well to inform users about the implications of using this flag. Consider using a description similar to the one in action.yml for consistency and clarity.
| Bypass the confirmation prompt. | |
| Pass 'true' to use the --force flag with firebase deploy. This will automatically accept any warning or prompts during deploy. Use with caution. |
Co-authored-by: Jeff <[email protected]>
Just updating the README to account for the addition for 'force' command.