Skip to content

fix angular19 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 22, 2024
Merged

fix angular19 #277

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ceb45b
fix angular19
Yuangwang Nov 22, 2024
51ce768
remove unused fields
Yuangwang Nov 22, 2024
e79243b
add comment
Yuangwang Nov 22, 2024
5c9903a
Merge branch 'main' into fix_angular19
Yuangwang Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@apphosting/adapter-angular/src/interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,7 @@ export const buildManifestSchema = z.object({
server: z.optional(url),
browser: url,
}),
prerenderedRoutes: z.optional(z.string().array()),
Copy link
Collaborator

@taeold taeold Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can comment this out for now and add that the type is different between v19 and v18? Might be helpful later when we actually end up using this field.

Copy link
Collaborator Author

@Yuangwang Yuangwang Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

// angular v18 has an array type and v19 has an object type
// We should uncomment this when we need to use prerenderedRoutes
// prerenderedRoutes: z.optional(z.union([z.string().array(), z.object({})])),
});
Loading