Skip to content

Bug/fix nextjs adapter functional tests #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2025
Merged

Bug/fix nextjs adapter functional tests #305

merged 4 commits into from
Feb 25, 2025

Conversation

@mathu97
Copy link
Collaborator

@mathu97 mathu97 commented Feb 25, 2025 •
edited
Loading

Was getting eslint errors and failing E2E errors when running npm run test from the NextJS adapter. This PR:

  1. updates the basic nextjs project to use eslint.config.mjs instead of .eslintrc.json, which seems to be the preferred way for Next 15
  2. Fixes breaking e2e tests for the NextJS adapter as they're breaking (could be the Next 15 upgrade: Upgrade Nextjs apphosting starter to Nextjs 15 #247)

@mathu97 mathu97 marked this pull request as ready for review February 25, 2025 17:38
@mathu97 mathu97 requested a review from annajowang February 25, 2025 17:39
@mathu97 mathu97 mentioned this pull request Feb 25, 2025
Merged
6 tasks
@mathu97 mathu97 merged commit e5d1b88 into main Feb 25, 2025
10 checks passed
@mathu97 mathu97 deleted the bug/fix-nextjs-adapter-functional-tests branch February 25, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuangwang Yuangwang Yuangwang approved these changes

@sjjj986 sjjj986 Awaiting requested review from sjjj986 sjjj986 is a code owner

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels jamesdaniels is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@blidd-google blidd-google Awaiting requested review from blidd-google blidd-google is a code owner

@taeold taeold Awaiting requested review from taeold taeold is a code owner

@leoortizz leoortizz Awaiting requested review from leoortizz leoortizz is a code owner

@annajowang annajowang Awaiting requested review from annajowang annajowang is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mathu97 @Yuangwang