Skip to content

Make Angular manifest parsing more robust #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025
Merged

Make Angular manifest parsing more robust #311

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
979e7be
Parse out new lines for angular manifest parsing
Yuangwang Mar 11, 2025
f9ad506
bump version
Yuangwang Mar 12, 2025
3376917
lint
Yuangwang Mar 12, 2025
adc8f97
add todo
Yuangwang Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@apphosting/adapter-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apphosting/adapter-angular",
"version": "17.2.12",
"version": "17.2.13",
"main": "dist/index.js",
"description": "Experimental addon to the Firebase CLI to add web framework support",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/@apphosting/adapter-angular/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@

export function parseOutputBundleOptions(buildOutput: string): OutputBundleOptions {
const strippedManifest = extractManifestOutput(buildOutput);
const parsedManifest = JSON.parse(strippedManifest) as string;
const parsedManifest = JSON.parse(strippedManifest.replace(/[\r\n]+/g, '')) as string;

Check failure on line 111 in packages/@apphosting/adapter-angular/src/utils.ts

View workflow job for this annotation

GitHub Actions / Lint 

Replace `''` with `""`
const manifest = buildManifestSchema.parse(parsedManifest);
if (manifest["errors"].length > 0) {
// errors when extracting manifest
Expand Down
Loading