Skip to content

Revert "Filter out node_modules" #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Revert "Filter out node_modules" #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f25235
Revert "Filter out node_modules (#346)"
mathu97 Jul 7, 2025
a3234d0
bump nextjs adapter version to 14.0.16
mathu97 Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@apphosting/adapter-nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apphosting/adapter-nextjs",
"version": "14.0.15",
"version": "14.0.16",
"main": "dist/index.js",
"description": "Experimental addon to the Firebase CLI to add web framework support",
"repository": {
Expand Down
4 changes: 0 additions & 4 deletions packages/@apphosting/adapter-nextjs/src/bin/build.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ metadata:
adapterVersion: ${adapterMetadata.adapterVersion}
framework: nextjs
frameworkVersion: ${defaultNextVersion}
outputFiles:
serverApp:
include:
- .next/standalone
`,
};
validateTestFiles(tmpDir, expectedFiles);
Expand Down
9 changes: 1 addition & 8 deletions packages/@apphosting/adapter-nextjs/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,7 @@ async function moveResources(
for (const path of pathsToMove) {
const isbundleYamlDir = join(appDir, path) === dirname(bundleYamlPath);
const existsInOutputBundle = await exists(join(outputBundleAppDir, path));
// Keep apphosting.yaml files in the root directory still, as later steps expect them to be there
const isApphostingYaml = path === "apphosting_preprocessed" || path === "apphosting.yaml";
if (!isbundleYamlDir && !existsInOutputBundle && !isApphostingYaml) {
if (!isbundleYamlDir && !existsInOutputBundle) {
await move(join(appDir, path), join(outputBundleAppDir, path));
}
}
Expand Down Expand Up @@ -192,11 +190,6 @@ async function generateBundleYaml(
framework: "nextjs",
frameworkVersion: nextVersion,
},
outputFiles: {
serverApp: {
include: [".next/standalone"], // we're only including the standalone directory to exclude the node_modules folder specifically
},
},
};
await writeFile(opts.bundleYamlPath, yamlStringify(outputBundle));
return;
Expand Down