Skip to content

Restore Next config after build. #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Restore Next config after build. #364

wants to merge 8 commits into from

Conversation

annajowang
Copy link
Collaborator

@annajowang annajowang commented Jul 30, 2025

We want this as part of making adapter builds idempotent

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @annajowang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the Next.js adapter's build process by ensuring that the user's original Next.js configuration is restored after the build completes. Furthermore, it transitions the handling of build artifacts from destructive 'move' operations to non-destructive 'copy' operations, thereby preserving the integrity of the source directory and preventing unintended side effects on the user's project files.

Highlights

  • Next.js Config Restoration: I've implemented a mechanism to restore the user's next.config.js file to its original state after the build process. This prevents any permanent modifications to the user's source code that might occur during the build optimization steps.
  • Non-Destructive Build Artifact Handling: The build process now copies static assets and other necessary resources to the output directory instead of moving them. This ensures that the original files remain untouched in the source project directory, making the build process non-destructive.
  • Updated Build Tests: I've modified existing tests to validate the new copy behavior. This includes adding new expected files to assertions and updating test descriptions to accurately reflect that files are now copied, not moved, ensuring the robustness of the build process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@annajowang annajowang changed the base branch from main to move-copy July 30, 2025 17:14
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces valuable improvements: copying build resources instead of moving them, and restoring the user's next.config.js after the build. These changes correctly prevent modifications to the user's source tree. The implementation is solid, but I've suggested one high-priority change to make the config restoration more robust. I also have a couple of medium-priority suggestions to improve the documentation and conciseness of the new restoreNextConfig function, and to ensure consistency in file handling by using copy instead of move where appropriate. Overall, great work!

@annajowang annajowang changed the base branch from move-copy to main August 1, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant