-
Notifications
You must be signed in to change notification settings - Fork 287
Restore Next config after build. #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @annajowang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a mechanism to automatically restore the user's original Next.js configuration file after the build process completes. This ensures that any temporary modifications made to the configuration during the build are reverted, leaving the user's source code untouched and preventing unintended side effects, even if the build encounters errors.
Highlights
- Next.js Config Restoration: Implemented a new
restoreNextConfigutility to ensure the user'snext.configfile is reverted to its original state after the build process. - Robust Build Process: Wrapped the Next.js build and subsequent output generation in a
try...finallyblock to guarantee thenext.configrestoration, even if the build fails. - Enhanced Test Coverage: Added new unit tests for the
restoreNextConfigutility covering various scenarios, and an end-to-end test to validate the config restoration behavior in a real build environment.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to restore the user's Next.js configuration after the build process, using a try...finally block to ensure it runs even on failure. This is a great improvement for robustness. The changes are supported by new unit and end-to-end tests.
My review has identified a critical issue in the restore logic that could lead to the user's config file not being restored in a specific failure case. I've also found a bug in a new e2e test and a point of confusion in a test assertion message. I've provided suggestions to fix these issues.
We want this as part of making adapter builds idempotent.
Tested a basic nextjs app with pack