-
Notifications
You must be signed in to change notification settings - Fork 284
Add common function to update .gitignore. #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b4cd6ec
Add common function to update .gitignore.
annajowang ffcf43d
Address bot comments
annajowang ca94ea2
Update packages/@apphosting/common/src/index.ts
annajowang a2b7335
Update packages/@apphosting/common/src/index.ts
annajowang 747a05d
Apply suggestions from code review
annajowang 051fbb1
fix stupid mess made by stupid bot
annajowang a040af0
lint bot's bad code
annajowang 9c03ce9
lint
annajowang 20d6565
Merge branch 'main' into gitignore
annajowang 70cf87d
Update common package version
annajowang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import assert from "assert"; | ||
| import fs from "fs"; | ||
| import path from "path"; | ||
| import os from "os"; | ||
| import { updateOrCreateGitignore } from "./index"; | ||
|
|
||
| describe("update or create .gitignore", () => { | ||
| let tmpDir: string; | ||
| beforeEach(() => { | ||
| tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "test-gitignore")); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| fs.rmSync(tmpDir, { recursive: true, force: true }); | ||
| }); | ||
|
|
||
| it(".gitignore file exists and is correctly updated with missing paths", () => { | ||
| fs.writeFileSync(path.join(tmpDir, ".gitignore"), "existingpath/"); | ||
|
|
||
| updateOrCreateGitignore(tmpDir, ["existingpath/", "newpath/"]); | ||
|
|
||
| const gitignoreContent = fs.readFileSync(path.join(tmpDir, ".gitignore"), "utf-8"); | ||
| assert.equal(`existingpath/\nnewpath/`, gitignoreContent); | ||
| }); | ||
| it(".gitignore file does not exist and is created", () => { | ||
| updateOrCreateGitignore(tmpDir, ["chickenpath/", "newpath/"]); | ||
| const gitignoreContent = fs.readFileSync(path.join(tmpDir, ".gitignore"), "utf-8"); | ||
| assert.equal(`chickenpath/\nnewpath/`, gitignoreContent); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.