Move all local build logic into a callable function. #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annajowang
changed the title
sjjj986
reviewed
Sep 23, 2025
| if (!existsSync(bundleYamlPath)) { | ||
| throw new Error(`Cannot load ${bundleYamlPath} from given path, it doesn't exist`); | ||
| } | ||
| return parseYaml(readFileSync(bundleYamlPath, "utf8")) as OutputBundleConfig; |
There was a problem hiding this comment.
Curious what is the reason for adding parse bundle.yaml as OutputBundleConfig here, how is it going to be used?
There was a problem hiding this comment.
The CLI will call it and use it to make the right apphosting createBuild and createRollout calls
annajowang
requested review from
a team,
blidd-google,
jamesdaniels,
leoortizz and
taeold
as code owners
annajowang
removed request for
Yuangwang,
blidd-google,
jamesdaniels,
leoortizz and
taeold
sjjj986
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ALL logic into a callable function also return the build output