Change FB_NELEM return type to unsigned and resolve all FB_NELEM related Wsign-compare warnings #8338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…related `Wsign-compare` warnings
AlexPeshkoff
approved these changes
Dec 4, 2024
dyemanov
approved these changes
Dec 4, 2024
Member
dyemanov
left a comment
dyemanov
left a comment
There was a problem hiding this comment.
I've added a few minor comments, but I'm not going to insist if you consider it unnecessary.
Contributor
Author
|
I've missed one warning in the sort.cpp file and fixed it in the last commit |
Contributor
|
A lot of conflict will be caused by this PR to others. Perhaps they should be merged first. |
Contributor
Author
Hello. I think enough time has passed to merge it |
Contributor
|
Still over 60 pull requests in the queue before yours. |
Member
True, but they're reviewed/merged out of order. If some of them are affected (I highly doubt there will be many), they'll need to be updated before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FB_NELEMreturns the size of the input array, which is always unsigned, but the function returns an int. It is a bit confusing, so I decided to change the type. It fixed someWsign-comparewarnings but added a bunch of new ones. Therefore, I included resolving them in the PR.