Fix potential deadlock when starting the encryption thread #8403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the thread where we release the attachment. If they match, use a dummy mutex instead of the actual dbb_thread_mutex to avoid a deadlock
MochalovAlexey
changed the title
…crypto thread handle
hvlad
reviewed
Jan 22, 2025
hvlad
reviewed
Jan 22, 2025
dyemanov
pushed a commit
that referenced
this pull request
Jan 27, 2025
* add a check to verify thread matching between the encryption thread and the thread where we release the attachment. If they match, use a dummy mutex instead of the actual dbb_thread_mutex to avoid a deadlock * fix Windows build by introducing a method to retrieve thread id from crypto thread handle * rename the crypt process thread id variable to its actual purpose as handle --------- Co-authored-by: aleksey.mochalov <[email protected]>
dyemanov
pushed a commit
that referenced
this pull request
Jan 27, 2025
* add a check to verify thread matching between the encryption thread and the thread where we release the attachment. If they match, use a dummy mutex instead of the actual dbb_thread_mutex to avoid a deadlock * fix Windows build by introducing a method to retrieve thread id from crypto thread handle * rename the crypt process thread id variable to its actual purpose as handle --------- Co-authored-by: aleksey.mochalov <[email protected]>
MochalovAlexey
pushed a commit
to MochalovAlexey/firebird
that referenced
this pull request
Jan 27, 2025
…QL#8403) B3_0_Release backport add a check to verify thread matching between the encryption thread and the thread where we release the attachment. If they match, use a dummy mutex instead of the actual dbb_thread_mutex to avoid a deadlock
dyemanov
pushed a commit
that referenced
this pull request
Jan 28, 2025
…_0_Release backport (#8412) add a check to verify thread matching between the encryption thread and the thread where we release the attachment. If they match, use a dummy mutex instead of the actual dbb_thread_mutex to avoid a deadlock Co-authored-by: aleksey.mochalov <[email protected]>
dyemanov
added a commit
that referenced
this pull request
Mar 12, 2025
…ad_t) conversions that does not work properly (it mangles the value on my Linux box, causing deadlocks in exactly the same place that was fixed by PR #8403)
dyemanov
added a commit
that referenced
this pull request
Mar 13, 2025
…ad_t) conversions that does not work properly (it mangles the value on my Linux box, causing deadlocks in exactly the same place that was fixed by PR #8403)
dyemanov
added a commit
that referenced
this pull request
Mar 13, 2025
…ad_t) conversions that does not work properly (it mangles the value on my Linux box, causing deadlocks in exactly the same place that was fixed by PR #8403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8402
add a check to verify thread matching between the encryption thread and the thread where we release the attachment. If they match, use a dummy mutex instead of the actual
dbb_thread_mutexto avoid a deadlock