Fix incorrect maximum size when reading dbb parameter values in SHOW DATABASE #8413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2025 11:19
Incorrect maximum size occur for isc_info_oldest_transaction, isc_info_oldest_active, isc_info_oldest_snapshot, isc_info_next_transaction. Also change maximum size for all parameter values, so we don't get the same error in future.
dyemanov
approved these changes
Feb 3, 2025
dyemanov
pushed a commit
that referenced
this pull request
Feb 3, 2025
…DATABASE (#8413) * Fix incorrect maximum size when reading dbb parameter values Incorrect maximum size occur for isc_info_oldest_transaction, isc_info_oldest_active, isc_info_oldest_snapshot, isc_info_next_transaction. Also change maximum size for all parameter values, so we don't get the same error in future. * Cast transaction number to correct type --------- Co-authored-by: Artyom Ivanov <[email protected]>
Member
|
Backported to v5 in the simplified form, without transaction numbers format change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect maximum size occurs for
isc_info_oldest_transaction,isc_info_oldest_active,isc_info_oldest_snapshot,isc_info_next_transactionandisc_info_limbo. This leads to an error if the value is greater thanint.Also change maximum size for all parameter values, so we don't get the same error in future.
This bug also occurs in v3.0, v4.0 and v5.0. In v4.0 and v5.0 it can be easily cherry picked, but in v3.0 TraNumber is a signed type, so printf has to be changed.