Fix windows warnings (C4554, C4018) and mark error message constants as constexpr (C26814) #8497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as constexpr (C26814)
asfernandes
reviewed
Apr 3, 2025
src/include/firebird/iberror.h
Outdated
| const ISC_STATUS isc_arg_warning = 18; // warning argument | ||
| const ISC_STATUS isc_arg_sql_state = 19; // SQLSTATE | ||
| #if __cplusplus >= 201703L // C++17 or later | ||
| #define STATUS_CONST inline constexpr ISC_STATUS |
Member
There was a problem hiding this comment.
This is public header, so I think some FB-specific prefix in the macro is good.
Also, it should be good to undefine it after usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for my previous PR: /pull/8360.
I apologize for having to reopen it. The code is the same except for corrections addressing the last two issues from the original PR.