Fixed crash after calling incorrectly parametrized request

[Ev3nt]

Init table:

CREATE TABLE dept (id NUMERIC(2), name VARCHAR(14), location VARCHAR(13));

If we execute procedure with incorrectrly paramerized request, we have an error (as expected):

EXECUTE BLOCK 
AS 
     DECLARE sql_stmt    VARCHAR(200);
     DECLARE dept_id     NUMERIC(2) = 50;
     DECLARE dept_name   TYPE OF COLUMN dept.name  = 'PERSONNEL';
     DECLARE location    TYPE OF COLUMN dept.location default 'DALLAS';
BEGIN
    sql_stmt = 'INSERT INTO dept VALUES (:A, :B, :C)';
    EXECUTE STATEMENT (:sql_stmt) (:dept_id, :dept_name, :location);
END;

Statement failed, SQLSTATE = 42S22
Dynamic SQL Error
-SQL error code = -206
-Column unknown
-A
-At line 1, column 26
-At block line: 9, col: 5

But when we make it correctly and try incorrectly request again, we have a crash. Correctly request:

EXECUTE BLOCK 
AS 
     DECLARE sql_stmt    VARCHAR(200);
     DECLARE dept_id     NUMERIC(2) = 50;
     DECLARE dept_name   TYPE OF COLUMN dept.name  = 'PERSONNEL';
     DECLARE location    TYPE OF COLUMN dept.location default 'DALLAS';
BEGIN
    sql_stmt = 'INSERT INTO dept VALUES (:A, :B, :C)';
    EXECUTE STATEMENT (:sql_stmt) (A := :dept_id, B :=  :dept_name, C :=  :location);
END;

I added 2 conditions to check if names is not a nullptr.
Now it throws an exception:

Statement failed, SQLSTATE = 42000
Input parameter 'A' have no value set
-At block line: 9, col: 5

[hvlad]

But when we make it correctly and try incorrectly request again

I can't understand this statement

[hvlad]

Can't reproduce. Using Firebird 5.0.3 :

SQL> create database 'inet://z:\temp\8666.fdb';
SQL>
SQL> CREATE TABLE dept (id NUMERIC(2), name VARCHAR(14), location VARCHAR(13));
SQL>
SQL> set term ^;
SQL>
SQL> EXECUTE BLOCK
CON> AS
CON>      DECLARE sql_stmt    VARCHAR(200);
CON>      DECLARE dept_id     NUMERIC(2) = 50;
CON>      DECLARE dept_name   TYPE OF COLUMN dept.name  = 'PERSONNEL';
CON>      DECLARE location    TYPE OF COLUMN dept.location default 'DALLAS';
CON> BEGIN
CON>     sql_stmt = 'INSERT INTO dept VALUES (:A, :B, :C)';
CON>     EXECUTE STATEMENT (:sql_stmt) (:dept_id, :dept_name, :location);
CON> END
CON> ^
Statement failed, SQLSTATE = 42S22
Dynamic SQL Error
-SQL error code = -206
-Column unknown
-A
-At line 1, column 26
-At block line: 9, col: 5
SQL>
SQL>
SQL> EXECUTE BLOCK
CON> AS
CON>      DECLARE sql_stmt    VARCHAR(200);
CON>      DECLARE dept_id     NUMERIC(2) = 50;
CON>      DECLARE dept_name   TYPE OF COLUMN dept.name  = 'PERSONNEL';
CON>      DECLARE location    TYPE OF COLUMN dept.location default 'DALLAS';
CON> BEGIN
CON>     sql_stmt = 'INSERT INTO dept VALUES (:A, :B, :C)';
CON>     EXECUTE STATEMENT (:sql_stmt) (A := :dept_id, B :=  :dept_name, C :=  :location);
CON> END
CON> ^
SQL>
SQL> set term ;^
SQL>
SQL> select * from dept;

     ID NAME           LOCATION
======= ============== =============
     50 PERSONNEL      DALLAS

SQL> rollback;
SQL> drop database;

[Ev3nt]

You need to retry with an incorrect request after a correct request.

[hvlad]

Reproduced now, thanks.

I think the following patch (at the beginning of Statement::setInParams()) is more correct:

	if (m_error = (!names && sqlCount))
	{
		// Parameter name expected
		ERR_post(Arg::Gds(isc_eds_prm_name_expected));
	}