Create IPC abstractions IpcMessage and IpcChat and use them in the Profiler #8703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfernandes
changed the title
asfernandes
force-pushed
the
work/profiler-ipc
branch
from
3f9d3f7 to
f16e9e9
Compare
asfernandes
force-pushed
the
work/profiler-ipc
branch
from
9f43b90 to
3ed85c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IpcMessage is unidirectional communication between client and server.
IpcChat is bidirectional communication where client sends a message to server and server replies.
The classes uses std::variant to deal with multiple message formats.