Refactor RuntimeStatistics to make it more extendable for future counters #8747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters (including grouped ones)
asfernandes
reviewed
Sep 22, 2025
| // Runtime statistics class | ||
| // Runtime statistics | ||
|
|
||
| enum class PageStatType |
Member
There was a problem hiding this comment.
Should these two enuns be int-based or could use a underlying smaller type?
Member
Author
There was a problem hiding this comment.
Given that we don't store it anywhere and it's always passed through stack, I think the default int is OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class enum)operator[])